feat: always make an HTTP call when calling self API methods #5017

frostming · 2024-10-10T09:20:12Z

Signed-off-by: Frost Ming [email protected]

What does this PR address?

Fixes #(issue)

Does the Pull Request follow Conventional Commits specification naming? Here are GitHub's
guide on how to create a pull request.
Does the code follow BentoML's code style, pre-commit run -a script has passed (instructions)?
Did you read through contribution guidelines and follow development guidelines?
Did your changes require updates to the documentation? Have you updated
those accordingly? Here are documentation guidelines and tips on writting docs.
Did you write tests to cover your changes?

Signed-off-by: Frost Ming <[email protected]>

src/_bentoml_impl/server/app.py

src/_bentoml_sdk/method.py

aarnphm

what is the reason for setting the self API to be WSGI?

what happens if users want to use async call?

src/_bentoml_impl/client/http.py

Signed-off-by: Frost Ming <[email protected]>

feat: always make an HTTP call when calling self API methods

e10057d

Signed-off-by: Frost Ming <[email protected]>

frostming requested a review from a team as a code owner October 10, 2024 09:20

frostming requested review from ssheng and removed request for a team October 10, 2024 09:20

aarnphm reviewed Oct 10, 2024

View reviewed changes

src/_bentoml_impl/server/app.py Show resolved Hide resolved

aarnphm reviewed Oct 10, 2024

View reviewed changes

src/_bentoml_sdk/method.py Show resolved Hide resolved

aarnphm reviewed Oct 10, 2024

View reviewed changes

frostming commented Oct 10, 2024

View reviewed changes

src/_bentoml_impl/client/http.py Show resolved Hide resolved

fix: clean import

d3cf125

Signed-off-by: Frost Ming <[email protected]>

aarnphm approved these changes Oct 10, 2024

View reviewed changes

frostming merged commit 045001c into bentoml:main Oct 11, 2024
49 of 51 checks passed

frostming deleted the feat/self-http-call branch October 11, 2024 00:32