Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Path issues with pip modules #4256

Closed
wants to merge 3 commits into from
Closed

fix: Path issues with pip modules #4256

wants to merge 3 commits into from

Conversation

tokotchd
Copy link

@tokotchd tokotchd commented Nov 2, 2023

Always prepend current bentofile directory to system path to avoid unwanted behavior when other bentofiles are on the system PATH
This is especially evident when trying to use bentoml cli on python folders that are also pip modules see #4217

@tokotchd
Always prepend current bentofile directory to system path to avoid un…
544d47e 
…wanted behavior when other bentofiles are on the system PATH

This is especially evident when trying to use bentoml cli on python folders that are also pip modules
see bentoml#4217
@tokotchd tokotchd requested a review from a team as a code owner November 2, 2023 17:13
@tokotchd tokotchd requested review from bojiang and removed request for a team November 2, 2023 17:13
sauyon
sauyon previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@aarnphm
Copy link
Contributor

aarnphm commented Nov 9, 2023 •
edited
Loading

we probably should note the side effect of doing this here

  • If there is a package/folder named grpc, it will override the default grpc import, which makes serve-grpc not working
  • the same as schema, or literally any folder that have the same name as package module imports.

@bojiang bojiang closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parano parano parano left review comments

@sauyon sauyon sauyon left review comments

@bojiang bojiang Awaiting requested review from bojiang bojiang is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tokotchd @aarnphm @parano @sauyon @bojiang