Search for contacts and deals #37
Conversation
protomolequle
force-pushed
the
feat/contacts-and-deals
branch
2 times, most recently
from
6fe6584 to
50727e0
Compare
protomolequle
force-pushed
the
feat/contacts-and-deals
branch
from
50727e0 to
cef044e
Compare
|
@protomolequle |
There was a problem hiding this comment.
@protomolequle
Thank you for adding this feature.
We would love to include this implementation in the library.
I would like to make it a little more general-purpose, allowing the user of the library to set things like Filter.
For example, the method name is simply Search, and the user of the library defines what to use for filtering.
I won't force you to go that far with this PR, but what do you think of the policy?
It would also be very helpful if you could add test code for the current code.
Thank you in advance.
|
Even if users specify filters, it may be better to predefine the ones that are likely to be used frequently, such as email and name. |
|
@kk-no, sure I can do that in a future PR. Making a more generalized search feature. |
|
@protomolequle |
|
@kk-no Yes, please do |
Description
Reviewers