Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add API integrations for contact and deals #36

Closed

Conversation

protomolequle
Copy link

@protomolequle protomolequle commented Feb 15, 2025

Description

  • Add API integration for contacts and deals on Hubspot
  • Upgraded codebase to Go 1.24
  • Cleanup formatting and linting issues in the package
  • Improved the Makefile for better usage

Acceptance criteria

  • All tests should pass as expected

@protomolequle protomolequle changed the title feat: code cleanup and upgrade to go 1.24 feat: add API integrations for contact and deals Feb 15, 2025
@kk-no kk-no self-requested a review February 17, 2025 00:30
@kk-no
Copy link
Member

kk-no commented Feb 17, 2025

@protomolequle
Thanks for creating the PR.
I checked the content and it seems to me that the scope is large, including additional features, tooling-related changes, and Go version updates.

Especially since we are releasing go-hubspot as OSS, we would like to carefully consider updating the Go version.

Since some of the changes are valid, could you please split the changes by context?

I will close this PR once.

@kk-no kk-no closed this Feb 17, 2025
@protomolequle
Copy link
Author

@kk-no sure, I'll create a new pr for the API integration for contacts and deals on Hubspot and another one for the linting fixes. The version upgrade is not necessary as well as the tooling stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants