#4270 - Update the Data Types to adapt to import #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dheepak-aot
changed the title
| @@ -53,6 +53,11 @@ export class SFASIntegrationProcessingService { | |||
| for (const filePath of filePaths) { | |||
| await this.processFile(filePath, processSummary); | |||
| } | |||
| if (!filePaths.length) { | |||
| processSummary.info( | |||
| "There are no files to be processed. But post file import operations will be executed.", | |||
There was a problem hiding this comment.
Minor, I would change as below.
There are no files to be processed, but post-file import operations will be executed.
andrewsignori-aot
approved these changes
Feb 7, 2025
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
sh16011993
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the testing done from SFAS file, data type of the following DB columns have been updated.
sims.sfas_individuals- columnphone_numberchanged to BIGINT.sims.sfas_applications- columnapplication_numberchanged to BIGINT.sims.sfas_applications- columngross_income_previous_yearchanged to NUMERIC(10,2).Note: Type casting wasn't used in the data type conversion expecting no data in the columns.
Rollback Evidence