Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4270 - SFAS Bridge Expansion - Import of new record types #4308

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dheepak-aot
Copy link
Collaborator

@dheepak-aot dheepak-aot commented Jan 30, 2025

Import of SFAS Application Dependants and SFAS Application Disbursements

Import

  • Added file record objects and import services for SFAS Application Dependants and SFAS Application Disbursements.
  • Updated the existing logic to log process summary warning when the record type is unknown instead of throwing error and aborting the import(existing logic).
    image

image

E2E Tests

  • Added E2E tests for import of new record types.
  • Added E2E Test for logging process summary warning on unknown record type in the file.

image

Launch File Update

  • Launch file updated to include the directory as well in the pattern while running current test file.

@dheepak-aot dheepak-aot self-assigned this Jan 30, 2025
@dheepak-aot dheepak-aot marked this pull request as ready for review February 1, 2025 01:23
Copy link

sonarqubecloud bot commented Feb 3, 2025

Copy link

github-actions bot commented Feb 3, 2025

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

Copy link

github-actions bot commented Feb 3, 2025

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.22% ( 3885 / 17488 )
Methods: 10.18% ( 226 / 2220 )
Lines: 25.53% ( 3351 / 13125 )
Branches: 14.37% ( 308 / 2143 )

Copy link

github-actions bot commented Feb 3, 2025

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 87.15% ( 1404 / 1611 )
Methods: 84.66% ( 160 / 189 )
Lines: 89.38% ( 1161 / 1299 )
Branches: 67.48% ( 83 / 123 )

Copy link

github-actions bot commented Feb 3, 2025

E2E SIMS API Coverage Report

Totals Coverage
Statements: 68.11% ( 6040 / 8868 )
Methods: 65.72% ( 744 / 1132 )
Lines: 71.97% ( 4731 / 6574 )
Branches: 48.62% ( 565 / 1162 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant