Skip to content

Commit

Permalink
Merge pull request #156 from aiuto/noconf
Browse files Browse the repository at this point in the history
Update comments about cfg=exec on license()
  • Loading branch information
aiuto authored Nov 7, 2024
2 parents 5b980ea + 9308dd1 commit a0bc8e7
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion rules/license.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@ _license = rule(
" should be listed here. If the user can choose a single one" +
" of many, then only list one here.",
providers = [LicenseKindInfo],
# This should be the null configuration, not the exec.
# Bazel 8+ users: In Bazel 8, the targets for package_metadata are
# always in a null configuration. This reflects the fact that they
# are non-configurable and keeps the node for a license in a single
# configuration, no matter what physical platforms you are building
# for.
# TODO: (after bazel 8.0 is mainstream): Remove this line.
cfg = "exec",
),
"copyright_notice": attr.string(
Expand Down

0 comments on commit a0bc8e7

Please sign in to comment.