Skip to content

Commit

Permalink
fix: allow license_text=None in license declaration
Browse files Browse the repository at this point in the history
There are many situations where the license kind is known but no license
file is available, e.g. some wheels downloaded from PyPi.

There are good reasons why one might want to prohibit that from a policy
perspective, but enforcing that policy is not the job of the license
rule itself, and the provided error message is not especially helpful
(and clearly not the intended outcome).

This doesn't alter the macro wrapper.  Any target that would be affected
by this change would have already been failing to build.

Closes #31
  • Loading branch information
adam-azarchs committed Oct 22, 2024
1 parent 773826c commit 10314dc
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion rules/license.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ _license = rule(
),
"license_text": attr.label(
allow_single_file = True,
default = "LICENSE",
doc = "The license file.",
),
"package_name": attr.string(
Expand Down

0 comments on commit 10314dc

Please sign in to comment.