Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload test logs with a UTF-8 content type #2117

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Nov 22, 2024

This fixes rendering of test .log files when opened in a browser.

Updating the deps was required to get the project to compile due to:

error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /Users/fmeum/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.56/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

Update command:

cargo update proc-macro2 --precise 1.0.60

This fixes rendering of test `.log` files when opened in a browser.

Updating the deps was required to get the project to compile due to:
```
error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /Users/fmeum/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.56/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^
```

Update command:
```
cargo update proc-macro2 --precise 1.0.60
```
@coeuvre coeuvre merged commit 96536e2 into bazelbuild:master Nov 22, 2024
3 of 4 checks passed
@fmeum fmeum deleted the utf8-testlogs branch November 22, 2024 15:33
@fmeum
Copy link
Contributor Author

fmeum commented Nov 22, 2024

Does this require a release/image update of some kind?

@coeuvre coeuvre mentioned this pull request Nov 26, 2024
coeuvre added a commit that referenced this pull request Nov 27, 2024
Changelog:
- Upload test logs with a UTF-8 content type #2117
@coeuvre
Copy link
Member

coeuvre commented Nov 27, 2024

Got error with this change:

Nov 27 15:10:10.119 ERROR bazelci_agent::artifact::upload: Failed to execute command `buildkite-agent artifact upload src/test/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutorTest/test.log --content_type=text/plain;encoding=utf-8`: exit status exit status: 1

The correct usage is:

buildkite-agent artifact upload [options] <pattern> [destination]

fweikert pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants