Change downstream projects configs to file_config #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fweikert
reviewed
Nov 9, 2023
fweikert
approved these changes
Nov 9, 2023
meteorcloudy
added a commit
that referenced
this pull request
Nov 9, 2023
This reverts commit a4b4e10. The commit breaks downstream: https://buildkite.com/bazel/bazel-at-head-plus-disabled/builds/1847#018bb630-70a4-46f1-9340-066445aa81da
meteorcloudy
added a commit
that referenced
this pull request
Nov 10, 2023
This reverts commit 95fede7.
|
The commit breaks downstream: https://buildkite.com/bazel/bazel-at-head-plus-disabled/builds/1847#018bb630-70a4-46f1-9340-066445aa81da I had to rollback at 95fede7 A new PR with fixes is available at: #1778 |
meteorcloudy
added a commit
that referenced
this pull request
Nov 10, 2023
Reapply #1776 with fixes: - We need to properly clone the git repository so that we can get `file_config` at the correct commit. - Refactored `downstream-root` so that we don't need to get platform info from task config for cloning the repo, which introduces a chicken-egg problem. - Allow suppressing stdout in `clone_git_repository` so that it won't impact stdout of `project_pipeline` - Make `validate_config` also work for downstream projects by adding `git_commit` as a parameter of `get_modified_files`.
fweikert
added a commit
to fweikert/continuous-integration
that referenced
this pull request
Nov 13, 2023
bazelbuild#1776 removed http_config entries for downstream projects, which caused auto sheriff to fail. With this change we no longer use "http_config : project name" mappings. Instead we extract the proejct name from the job label, which is a bit of a hack.
Merged
fweikert
added a commit
to fweikert/continuous-integration
that referenced
this pull request
Nov 13, 2023
bazelbuild#1776 removed http_config entries for downstream projects, which caused auto sheriff to fail. With this change we no longer use "http_config : project name" mappings. Instead we extract the project name from the job label, which is a bit of a hack.
fweikert
added a commit
that referenced
this pull request
Nov 13, 2023
#1776 removed http_config entries for downstream projects, which caused auto sheriff to fail. With this change we no longer use "http_config : project name" mappings. Instead we extract the project name from the job label, which is a bit of a hack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the downstream projects use a matching config file at the same last green commit of the project being tested.
For a few downstream projects, we have their config files in the CI repo, therefore we need to keep the
http_configfor them.Also deleted downstream configs for
rules_k8s,rules_appengineandSubparsince they are no longer active.Addressing #1759 (comment)