Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ncurses): support ncursesw #3545

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat(ncurses): support ncursesw #3545

merged 1 commit into from
Jan 9, 2025

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Jan 8, 2025 •
edited
Loading

closes #3530

@wep21
Copy link
Contributor Author

wep21 commented Jan 8, 2025

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Jan 8, 2025
@wep21
Copy link
Contributor Author

wep21 commented Jan 8, 2025

cc @davidzchen

@wep21
Copy link
Contributor Author

wep21 commented Jan 8, 2025

also cc @tongke6 @lalten @johnor who previously commit some updates to ncurses.

@wep21
Copy link
Contributor Author

wep21 commented Jan 9, 2025

@fmeum @meteorcloudy I'd like you to add presubmit auto run label.

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jan 9, 2025
tongke6
tongke6 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@tongke6 tongke6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meteorcloudy meteorcloudy merged commit 6294a11 into bazelbuild:main Jan 9, 2025
18 checks passed
@wep21 wep21 deleted the ncursesw branch January 9, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tongke6 tongke6 tongke6 approved these changes

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: ncurses module does not have wide character support
5 participants
@wep21 @meteorcloudy @tongke6 @fmeum @bazel-io