Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical distance for vertical cover #369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sh-nguyen
Copy link

Add option to specify the vertical distance from the workarea to the base of the fully extended vertical cover.

Description

Add new Window position variable that is used in calculating the position of the window.

Motivation and Context

This allows the workarea to be on a different plane to the bottom of the fully extended vertical cover.

How has this been tested?

Tested the formula change via simulation, and the integration via real world testing of two window shades that are different lengths mounted at the same height above the floor. Have confirmed that the bottom of the shades are level with each other throughout the day, when other parameters are kept the same.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking which updates existing code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Add option to specify the vertical distance from the workarea to the base of the fully extended vertical cover.
@@ -38,6 +38,7 @@
"data": {
"set_azimuth": "Window Azimuth",
"window_height": "Window Height",
"window_position": "Window Position",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a longer description of this new parameter in the "data_description" section so that it appears in the HA GUI during configuration. Then users don't have to come to GitHub and scroll through the README to figure out the meaning of this new parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants