Skip to content

Commit

Permalink
Merge pull request #237 from balancer/mkflow27/issue220
Browse files Browse the repository at this point in the history
Mkflow27/issue220
  • Loading branch information
danielmkm authored Jan 28, 2025
2 parents d236b01 + 903b20c commit d588aee
Show file tree
Hide file tree
Showing 5 changed files with 314 additions and 17 deletions.
84 changes: 74 additions & 10 deletions erc4626/StatATokenV2Review.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,15 @@
- [ethereum:0x7Bc3485026Ac48b6cf9BaF0A377477Fff5703Af8](https://etherscan.io/address/0x7bc3485026ac48b6cf9baf0a377477fff5703af8#readProxyContract)
- [ethereum:0x0FE906e030a44eF24CA8c7dC7B7c53A6C4F00ce9](https://etherscan.io/token/0x0fe906e030a44ef24ca8c7dc7b7c53a6c4f00ce9#readProxyContract)
- [ethereum:0x775F661b0bD1739349b9A2A3EF60be277c5d2D29](https://etherscan.io/token/0x775f661b0bd1739349b9a2a3ef60be277c5d2d29#readProxyContract)
-
- [base:0xe298b938631f750DD409fB18227C4a23dCdaab9b](https://basescan.org/address/0xe298b938631f750DD409fB18227C4a23dCdaab9b#code)
- [base:0x6acD0a165fD70A84b6b50d955ff3628700bAAf4b](https://basescan.org/address/0x6acD0a165fD70A84b6b50d955ff3628700bAAf4b#readProxyContract)
- [base:0xC768c589647798a6EE01A91FdE98EF2ed046DBD6](https://basescan.org/address/0xC768c589647798a6EE01A91FdE98EF2ed046DBD6#readProxyContract)
- [base:0xFA2A03b6f4A65fB1Af64f7d935fDBf78693df9aF](https://basescan.org/address/0xFA2A03b6f4A65fB1Af64f7d935fDBf78693df9aF#readProxyContract)
- [base:0x0830820D1A9aa1554364752d6D8F55C836871B74](https://basescan.org/address/0x0830820D1A9aa1554364752d6D8F55C836871B74#readProxyContract)
- [base:0x5e8B674127B321DC344c078e58BBACc3f3008962](https://basescan.org/address/0x5e8B674127B321DC344c078e58BBACc3f3008962#readProxyContract)
- [base:0x74D4D1D440c9679b1013999Bd91507eAa2fff651](https://basescan.org/address/0x74D4D1D440c9679b1013999Bd91507eAa2fff651#readProxyContract)
- [base:0xF8F10f39116716e89498c1c5E94137ADa11b2BC7](https://basescan.org/address/0xF8F10f39116716e89498c1c5E94137ADa11b2BC7#readProxyContract)

- Audit report(s):
- [StatATokenV2 audits](https://github.com/aave-dao/aave-v3-origin/blob/067d29eb75115179501edc4316d125d9773f7928/audits/11-09-2024_Certora_StataTokenV2.pdf)

Expand Down Expand Up @@ -100,6 +108,54 @@ If none of these is checked, then this might be a pretty great Rate Provider! If
- admin type: Aave governance system.
- multisig timelock? YES: 24 hours.

#### Wrapped Aave Base WETH - 0xe298b938631f750DD409fB18227C4a23dCdaab9b
- upgradeable component: `StataTokenV2` ([base:0xe298b938631f750DD409fB18227C4a23dCdaab9b](https://basescan.org/address/0xe298b938631f750DD409fB18227C4a23dCdaab9b#readProxyContract))
- admin address: [base:0x9390B1735def18560c509E2d0bc090E9d6BA257a](https://basescan.org/address/0x9390B1735def18560c509E2d0bc090E9d6BA257a#code)
- admin type: Aave governance system.
- multisig timelock? YES: 24 hours.

#### Wrapped Aave Base weETH - 0x6acD0a165fD70A84b6b50d955ff3628700bAAf4b
- upgradeable component: `StataTokenV2` ([base:0x6acD0a165fD70A84b6b50d955ff3628700bAAf4b](https://basescan.org/address/0x6acD0a165fD70A84b6b50d955ff3628700bAAf4b#readProxyContract))
- admin address: [base:0x9390B1735def18560c509E2d0bc090E9d6BA257a](https://basescan.org/address/0x9390B1735def18560c509E2d0bc090E9d6BA257a#code)
- admin type: Aave governance system.
- multisig timelock? YES: 24 hours.

#### Wrapped Aave Base USDC - 0xC768c589647798a6EE01A91FdE98EF2ed046DBD6
- upgradeable component: `StataTokenV2` ([base:0x6acD0a165fD70A84b6b50d955ff3628700bAAf4b](https://basescan.org/address/0x6acD0a165fD70A84b6b50d955ff3628700bAAf4b#readProxyContract))
- admin address: [base:0x9390B1735def18560c509E2d0bc090E9d6BA257a](https://basescan.org/address/0x9390B1735def18560c509E2d0bc090E9d6BA257a)
- admin type: Aave governance system.
- multisig timelock? YES: 24 hours.

#### Wrapped Aave Base cbBTC - 0xFA2A03b6f4A65fB1Af64f7d935fDBf78693df9aF
- upgradeable component: `StataTokenV2` ([base:0xFA2A03b6f4A65fB1Af64f7d935fDBf78693df9aF](https://basescan.org/address/0xFA2A03b6f4A65fB1Af64f7d935fDBf78693df9aF#readProxyContract))
- admin address: [base:0x9390B1735def18560c509E2d0bc090E9d6BA257a](https://basescan.org/address/0x9390B1735def18560c509E2d0bc090E9d6BA257a)
- admin type: Aave governance system.
- multisig timelock? YES: 24 hours.

#### Wrapped Aave Base wstETH - 0x0830820D1A9aa1554364752d6D8F55C836871B74
- upgradeable component: `StataTokenV2` ([base:0x0830820D1A9aa1554364752d6D8F55C836871B74](https://basescan.org/address/0x0830820D1A9aa1554364752d6D8F55C836871B74#readProxyContract))
- admin address: [base:0x9390B1735def18560c509E2d0bc090E9d6BA257a](https://basescan.org/address/0x9390B1735def18560c509E2d0bc090E9d6BA257a)
- admin type: Aave governance system.
- multisig timelock? YES: 24 hours.

#### Wrapped Aave Base cbETH - 0x5e8B674127B321DC344c078e58BBACc3f3008962
- upgradeable component: `StataTokenV2` ([base:0x5e8B674127B321DC344c078e58BBACc3f3008962](https://basescan.org/address/0x5e8B674127B321DC344c078e58BBACc3f3008962#readProxyContract))
- admin address: [base:0x9390B1735def18560c509E2d0bc090E9d6BA257a](https://basescan.org/address/0x9390B1735def18560c509E2d0bc090E9d6BA257a)
- admin type: Aave governance system.
- multisig timelock? YES: 24 hours.

#### Wrapped Aave Base USDbC - 0x74D4D1D440c9679b1013999Bd91507eAa2fff651
- upgradeable component: `StataTokenV2` ([base:0x74D4D1D440c9679b1013999Bd91507eAa2fff651](https://basescan.org/address/0x74D4D1D440c9679b1013999Bd91507eAa2fff651#readProxyContract))
- admin address: [base:0x9390B1735def18560c509E2d0bc090E9d6BA257a](https://basescan.org/address/0x9390B1735def18560c509E2d0bc090E9d6BA257a)
- admin type: Aave governance system.
- multisig timelock? YES: 24 hours.

#### Wrapped Aave Base ezETH - 0xF8F10f39116716e89498c1c5E94137ADa11b2BC7
- upgradeable component: `StataTokenV2` ([base:0xF8F10f39116716e89498c1c5E94137ADa11b2BC7](https://basescan.org/address/0xF8F10f39116716e89498c1c5E94137ADa11b2BC7))
- admin address: [base:0x9390B1735def18560c509E2d0bc090E9d6BA257a](https://basescan.org/address/0x9390B1735def18560c509E2d0bc090E9d6BA257a)
- admin type: Aave governance system.
- multisig timelock? YES: 24 hours.

### Common Manipulation Vectors
- [ ] The ERC4626 Vault is susceptible to donation attacks.

Expand All @@ -110,14 +166,22 @@ To save time, we do not bother pointing out low-severity/informational issues or
**Summary judgment: USABLE**

The outlined ERC4626 Vaults should work well with Balancer pools. Upgradeability is guarded by Aave governance and the Vaults implement the required interfaces with fork tests passing as can be seen here:
- [0x773cda0cade2a3d86e6d4e30699d40bb95174ff2](https://github.com/balancer/balancer-v3-erc4626-tests/blob/main/test/gnosis/ERC4626GnosisAaveGno.t.sol)
- [0x7c16F0185A26Db0AE7a9377f23BC18ea7ce5d644](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/gnosis/ERC4626GnosisAaveGno.t.sol#L20)
- [0x51350d88c1bd32cc6a79368c9fb70373fb71f375](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/gnosis/ERC4626GnosisAaveUsdce.t.sol#L20)
- [0x57f664882F762FA37903FC864e2B633D384B411A](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/gnosis/ERC4626GnosisAaveWeth.t.sol#L17)
- [0xD4fa2D31b7968E448877f69A96DE69f5de8cD23E](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/mainnet/ERC4626MainnetAaveUsdcV2.t.sol#L20)
- [0x0bfc9d54Fc184518A81162F8fB99c2eACa081202](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/mainnet/ERC4626MainnetAaveWeth.t.sol#L20)
- [0x7Bc3485026Ac48b6cf9BaF0A377477Fff5703Af8](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/mainnet/ERC4626MainnetAaveUsdt2.t.sol#L20)
- [0x0FE906e030a44eF24CA8c7dC7B7c53A6C4F00ce9](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/mainnet/ERC4626MainnetAaveLidoWeth.t.sol#L20)
- [0x775F661b0bD1739349b9A2A3EF60be277c5d2D29](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/mainnet/ERC4626MainnetAaveLidoWstEth.t.sol#L20)
- [gnosis:0x773cda0cade2a3d86e6d4e30699d40bb95174ff2](https://github.com/balancer/balancer-v3-erc4626-tests/blob/main/test/gnosis/ERC4626GnosisAaveGno.t.sol)
- [gnosis:0x7c16F0185A26Db0AE7a9377f23BC18ea7ce5d644](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/gnosis/ERC4626GnosisAaveGno.t.sol#L20)
- [gnosis:0x51350d88c1bd32cc6a79368c9fb70373fb71f375](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/gnosis/ERC4626GnosisAaveUsdce.t.sol#L20)
- [gnosis:0x57f664882F762FA37903FC864e2B633D384B411A](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/gnosis/ERC4626GnosisAaveWeth.t.sol#L17)
- [ethereum:0xD4fa2D31b7968E448877f69A96DE69f5de8cD23E](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/mainnet/ERC4626MainnetAaveUsdcV2.t.sol#L20)
- [ethereum:0x0bfc9d54Fc184518A81162F8fB99c2eACa081202](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/mainnet/ERC4626MainnetAaveWeth.t.sol#L20)
- [ethereum:0x7Bc3485026Ac48b6cf9BaF0A377477Fff5703Af8](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/mainnet/ERC4626MainnetAaveUsdt2.t.sol#L20)
- [ethereum:0x0FE906e030a44eF24CA8c7dC7B7c53A6C4F00ce9](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/mainnet/ERC4626MainnetAaveLidoWeth.t.sol#L20)
- [ethereum:0x775F661b0bD1739349b9A2A3EF60be277c5d2D29](https://github.com/balancer/balancer-v3-erc4626-tests/blob/365ee17e8904f4654990434cc3bbc273478d95ef/test/mainnet/ERC4626MainnetAaveLidoWstEth.t.sol#L20)
- Weth [base:0xe298b938631f750DD409fB18227C4a23dCdaab9b](https://github.com/balancer/balancer-v3-erc4626-tests/blob/aave-base/test/base/ERC4626BaseAaveWeth.t.sol)
- weETH [base:0x6acD0a165fD70A84b6b50d955ff3628700bAAf4b](https://github.com/balancer/balancer-v3-erc4626-tests/blob/208e800c185f59d3e57f4f228932af59d0458b29/test/base/ERC4626BaseAaveWeETH.t.sol#L20)
- USDC [base:0xC768c589647798a6EE01A91FdE98EF2ed046DBD6](https://github.com/balancer/balancer-v3-erc4626-tests/blob/208e800c185f59d3e57f4f228932af59d0458b29/test/base/ERC4626BaseAaveUSDC.t.sol#L20)
- cbBTC [base:0xFA2A03b6f4A65fB1Af64f7d935fDBf78693df9aF](https://github.com/balancer/balancer-v3-erc4626-tests/blob/208e800c185f59d3e57f4f228932af59d0458b29/test/base/ERC4626BaseAaveCbBTC.t.sol#L20)
- wstETH [base:0x0830820D1A9aa1554364752d6D8F55C836871B74](https://github.com/balancer/balancer-v3-erc4626-tests/blob/208e800c185f59d3e57f4f228932af59d0458b29/test/base/ERC4626BaseAaveWstETH.t.sol#L20)
- cbETH [base:0x5e8B674127B321DC344c078e58BBACc3f3008962](https://github.com/balancer/balancer-v3-erc4626-tests/blob/208e800c185f59d3e57f4f228932af59d0458b29/test/base/ERC4626BaseAaveCbETH.t.sol#L20)
- USDbC [base:0x74D4D1D440c9679b1013999Bd91507eAa2fff651](https://github.com/balancer/balancer-v3-erc4626-tests/blob/208e800c185f59d3e57f4f228932af59d0458b29/test/base/ERC4626BaseAaveUSDbC.t.sol#L20)
- ezETH [base:0xF8F10f39116716e89498c1c5E94137ADa11b2BC7](https://github.com/balancer/balancer-v3-erc4626-tests/blob/208e800c185f59d3e57f4f228932af59d0458b29/test/base/ERC4626BaseAaveEzETH.t.sol#L20)


64 changes: 61 additions & 3 deletions erc4626/registry.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,62 @@
{
"base": {
"0xe298b938631f750DD409fB18227C4a23dCdaab9b": {
"asset": "0x4200000000000000000000000000000000000006",
"name": "Wrapped Aave Base WETH",
"summary": "safe",
"review": "./StatATokenV2Review.md",
"warnings": []
},
"0x6acD0a165fD70A84b6b50d955ff3628700bAAf4b": {
"asset": "0x04C0599Ae5A44757c0af6F9eC3b93da8976c150A",
"name": "Wrapped Aave Base weETH",
"summary": "safe",
"review": "./StatATokenV2Review.md",
"warnings": []
},
"0xC768c589647798a6EE01A91FdE98EF2ed046DBD6": {
"asset": "0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913",
"name": "Wrapped Aave Base USDC",
"summary": "safe",
"review": "./StatATokenV2Review.md",
"warnings": []
},
"0xFA2A03b6f4A65fB1Af64f7d935fDBf78693df9aF": {
"asset": "0xcbB7C0000aB88B473b1f5aFd9ef808440eed33Bf",
"name": "Wrapped Aave Base cbBTC",
"summary": "safe",
"review": "./StatATokenV2Review.md",
"warnings": []
},
"0x0830820D1A9aa1554364752d6D8F55C836871B74": {
"asset": "0xc1CBa3fCea344f92D9239c08C0568f6F2F0ee452",
"name": "Wrapped Aave Base wstETH",
"summary": "safe",
"review": "./StatATokenV2Review.md",
"warnings": []
},
"0x5e8B674127B321DC344c078e58BBACc3f3008962": {
"asset": "0x2Ae3F1Ec7F1F5012CFEab0185bfc7aa3cf0DEc22",
"name": "Wrapped Aave Base cbETH",
"summary": "safe",
"review": "./StatATokenV2Review.md",
"warnings": []
},
"0x74D4D1D440c9679b1013999Bd91507eAa2fff651": {
"asset": "0xd9aAEc86B65D86f6A7B5B1b0c42FFA531710b6CA",
"name": "Wrapped Aave Base USDbC",
"summary": "safe",
"review": "./StatATokenV2Review.md",
"warnings": []
},
"0xF8F10f39116716e89498c1c5E94137ADa11b2BC7": {
"asset": "0x2416092f143378750bb29b79eD961ab195CcEea5",
"name": "Wrapped Aave Base ezETH",
"summary": "safe",
"review": "./StatATokenV2Review.md",
"warnings": []
}
},
"ethereum": {
"0x2371e134e3455e0593363cBF89d3b6cf53740618": {
"asset": "0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2",
Expand Down Expand Up @@ -143,21 +201,21 @@
"warnings": []
}
},
"sonic":{
"sonic": {
"0xA28d4dbcC90C849e3249D642f356D85296a12954": {
"asset": "0xCC0966D8418d412c599A6421b760a847eB169A8c",
"name": "Static Avalon Sonic SolvBTC.bbn",
"summary": "safe",
"review": "./StaticATokenLMAvalonReview.md",
"warnings": []
},
},
"0xD31E89Ffb929b38bA60D1c7dBeB68c7712EAAb0a": {
"asset": "0x541FD749419CA806a8bc7da8ac23D346f2dF8B77",
"name": "Static Avalon Sonic SolvBTC",
"summary": "safe",
"review": "./StaticATokenLMAvalonReview.md",
"warnings": []
},
},
"0x7870ddFd5ACA4E977B2287e9A212bcbe8FC4135a": {
"asset": "0x29219dd400f2Bf60E5a23d13Be72B486D4038894",
"name": "Beefy USDC Wrapper for SiloV2",
Expand Down
Loading

0 comments on commit d588aee

Please sign in to comment.