Add first wave of morpho base vaults #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattPereira
commented
Jan 24, 2025
| wrapper = IERC4626(0x5A32099837D89E3a794a44fb131CBbAD41f87a8C); | ||
| // Donor of WETH tokens | ||
| underlyingDonor = 0x46a83dC1a264Bff133dB887023d2884167094837; | ||
| amountToDonate = 1e1 * 1e18; |
There was a problem hiding this comment.
had to lower this amountToDonate for WETH compared to the examples on mainnet which are 1e5 * 1e18. Test fails otherwise
There was a problem hiding this comment.
It depends on the token donor. I changed the donor (by checking the token holders of the underlying token) and could test it with 1e3. (But 1e1 would do just fine too :) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated with balancer/code-review#229
Morpho Base Vaults
Debug