Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example #5

Merged
merged 1 commit into from
Mar 5, 2022
Merged

New example #5

merged 1 commit into from
Mar 5, 2022

Conversation

danpovey
Copy link
Contributor

@danpovey danpovey commented Mar 5, 2022

No description provided.

@danpovey
Copy link
Contributor Author

danpovey commented Mar 5, 2022

Some notes:
I added the file Example2_StartRTCMBase.cpp, which is modified from SparkFun_u-blox_GNSS_Arduino_Library/examples/NEO-M8P-2/Example2_StartRTCMBase/Example2_StartRTCMBase.ino and
changed a bit to compile on Linux. The changes just consisted of adding missing includes, replacing a type-cast
to string with a type-cast to integer in a print statement (and removing another type-cast of float to string).

There are some warnings remaining, but also a couple of compilation errors which it wasn't clear to me how to fix:

zed
/ceph-dan/Ublox_Linux_Library/linux_examples/Example2_StartRTCMBase.cpp: In function 'void setup()':
/ceph-dan/Ublox_Linux_Library/linux_examples/Example2_StartRTCMBase.cpp:52:8: error: 'class TwoWire' has no member named 'begin'
   Wire.begin();
        ^~~~~
/ceph-dan/Ublox_Linux_Library/linux_examples/Example2_StartRTCMBase.cpp:53:8: error: 'class TwoWire' has no member named 'setClock'
   Wire.setClock(400000); //Increase I2C clock speed to 400kHz
        ^~~~~~~~

... now, these calls may not actually be necessary in the implementation of TwoWire that you are using, but
I'm not sure, so I feel it's safer to let someone who knows about this deal with the issue.

I also experimented with moving forward the submodule from version 2.0.5 to version 2.1.5 of https://github.com/sparkfun/SparkFun_u-blox_GNSS_Arduino_Library, but this caused build errors with
header SPI.h not being found, that I was not sure how to resolve.

@danpovey
Copy link
Contributor Author

danpovey commented Mar 5, 2022

... sorry, I actually intended to make this pull request to my own repository, but I'll leave it here as you may be able to comment.

@balamuruganky balamuruganky merged commit c3377f3 into balamuruganky:master Mar 5, 2022
@balamuruganky
Copy link
Owner

@danpovey : Thanks for using this code base and your contribution. Much appreciated!!!

@danpovey
Copy link
Contributor Author

danpovey commented Mar 5, 2022

Thanks for merging, but please note that it has compilation errors, as I mentioned above!! I don't want to break peoples' work...

@balamuruganky
Copy link
Owner

@danpovey : This PR has been removed now, Could you please check the i2c example and change the code accordingly? Thanks,

@danpovey
Copy link
Contributor Author

danpovey commented Mar 5, 2022

OK, see #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants