Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

logthrdestdrv: update tutorial #69

Merged
merged 1 commit into from
Aug 24, 2020
Merged

logthrdestdrv: update tutorial #69

merged 1 commit into from
Aug 24, 2020

Conversation

furiel
Copy link
Collaborator

@furiel furiel commented Jun 26, 2020 •
edited
Loading

  • use of skeleton generator
  • simplifications due to skeleton generator
  • using cmake files
  • fixing api: adding deinit, moving connect out of thread_init
  • proper driver-worker separation
  • the driver will actually write to file
  • the driver contains thread specific information as example (pthread id)
  • a little more explanation on the interface

@furiel furiel force-pushed the update-thrdestdrv branch from 0b96654 to 40b4db0 Compare June 26, 2020 06:45
gaborznagy
gaborznagy reviewed Jun 26, 2020
View reviewed changes
Copy link
Contributor

@gaborznagy gaborznagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished completely, but I share my comments in the meantime.

@furiel furiel force-pushed the update-thrdestdrv branch from 40b4db0 to 0389dfd Compare July 28, 2020 08:20
@furiel furiel changed the title logthrdestdrv: updating description [WIP] logthrdestdrv: updating description Jul 28, 2020
@furiel furiel force-pushed the update-thrdestdrv branch 2 times, most recently from e23cea0 to 266048a Compare July 28, 2020 10:31
@furiel furiel changed the title [WIP] logthrdestdrv: updating description logthrdestdrv: updating description Jul 28, 2020
@furiel furiel changed the title logthrdestdrv: updating description logthrdestdrv: update tutorial Jul 28, 2020
@furiel
Copy link
Collaborator Author

furiel commented Jul 28, 2020

@Kokan @gaborznagy thank you for your reviews. I updated the PR again. A significant portion of the PR is changed. So please look at it as a whole again.

gaborznagy
gaborznagy reviewed Jul 30, 2020
View reviewed changes
Copy link
Contributor

@gaborznagy gaborznagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor stuff (typos), otherwise approve

@furiel furiel force-pushed the update-thrdestdrv branch from 266048a to 05923ae Compare July 31, 2020 06:42
gaborznagy
gaborznagy approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@gaborznagy gaborznagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big approve!

@szemere szemere self-requested a review August 11, 2020 12:03
szemere
szemere approved these changes Aug 24, 2020
View reviewed changes
Copy link
Collaborator

@szemere szemere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo. Very nice guide!

@furiel
logthrdestdrv: update
44af5f5 
Signed-off-by: Antal Nemes <[email protected]>
@furiel furiel force-pushed the update-thrdestdrv branch from 05923ae to 44af5f5 Compare August 24, 2020 05:19
@furiel furiel merged commit d804c60 into master Aug 24, 2020
@furiel furiel deleted the update-thrdestdrv branch August 24, 2020 05:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kokan Kokan Kokan left review comments

@gaborznagy gaborznagy gaborznagy approved these changes

@szemere szemere szemere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@furiel @Kokan @gaborznagy @szemere