Skip to content

Commit

Permalink
⚠️ Removed compiler warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
aym-n committed Jan 11, 2024
1 parent 5fe0ea5 commit b1120cb
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/functions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ impl Function {
}

pub fn bind(&self, instance: &Object) -> Object {
let mut e = RefCell::new(Environment::new_with_enclosing(Rc::clone(&self.closure)));
let e = RefCell::new(Environment::new_with_enclosing(Rc::clone(&self.closure)));
e.borrow_mut().define("this".to_string(), instance.clone());
Object::Function(Rc::new(Self {
name: self.name.clone(),
Expand Down
4 changes: 2 additions & 2 deletions src/interpreter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ impl ExprVisitor<Object> for Interpreter {
self.look_up_variable(&expr.keyword, wrapper)
}

fn visit_set_expr(&self, wrapper: Rc<Expr>, expr: &SetExpr) -> Result<Object, Error> {
fn visit_set_expr(&self, _wrapper: Rc<Expr>, expr: &SetExpr) -> Result<Object, Error> {
let object = self.evaluate(expr.object.clone())?;

if let Object::Instance(inst) = object {
Expand All @@ -204,7 +204,7 @@ impl ExprVisitor<Object> for Interpreter {
))
}

fn visit_get_expr(&self, wrapper: Rc<Expr>, expr: &GetExpr) -> Result<Object, Error> {
fn visit_get_expr(&self, _wrapper: Rc<Expr>, expr: &GetExpr) -> Result<Object, Error> {
let object = self.evaluate(expr.object.clone())?;

if let Object::Instance(inst) = object {
Expand Down
8 changes: 4 additions & 4 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ mod instance;

fn eval(source: &str) -> Result<(), Error> {
let lexer = Lexer::new(source.to_string());
let mut tokens: Vec<Token> = lexer.collect();
let tokens: Vec<Token> = lexer.collect();

let mut parser = Parser::new(tokens);
let statements = parser.parse();
Expand Down Expand Up @@ -67,15 +67,15 @@ fn repl() {
"@" => interpreter.print_env(),
_ => {
let lexer = Lexer::new(input);
let mut tokens: Vec<Token> = lexer.collect();
let tokens: Vec<Token> = lexer.collect();

let mut parser = Parser::new(tokens);
let statements = parser.parse();

match statements {
Ok(statements) => {
let s = Rc::new(statements);
let mut resolver = Resolver::new(&interpreter);
let resolver = Resolver::new(&interpreter);
resolver.resolve(&Rc::clone(&s));

if resolver.success() {
Expand All @@ -85,7 +85,7 @@ fn repl() {
}

}
Err(e) => println!("Error"),
Err(_) => std::process::exit(2),
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/resolver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,11 @@ impl<'a> Resolver<'a> {
}

fn resolve_stmt(&self, stmt: Rc<Stmt>){
stmt.accept(stmt.clone(), self);
let _ = stmt.accept(stmt.clone(), self);
}

fn resolve_expr(&self, expr: Rc<Expr>){
expr.accept(expr.clone(), self);
let _ = expr.accept(expr.clone(), self);
}

fn begin_scope(&self) {
Expand Down
1 change: 0 additions & 1 deletion src/tokens.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use std::fmt;
use crate::callable::Callable;
use crate::errors::*;
use crate::interpreter::Interpreter;
use crate::callable::*;
Expand Down

0 comments on commit b1120cb

Please sign in to comment.