-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telescope): support live preview of currently selected colorscheme #1085
Conversation
Signed-off-by: Cyberczy <[email protected]>
before.mp4 |
after.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, alpha.lua
is also needed to change.
yup, I had that problem too,and I'll try to fix it later |
nice work! |
I made the same change in |
it.didn.t.work.mp4 |
2023-11-30.16-38-53.mp4In this video, you can clearly see that the README.md file works properly, but the nvim-tree file does not |
yup, but I'm running out of ideas |
AFAIU this is the expected behavior under the current implementation. Since these buffers aren't included in the listed buffer list, there's no simple way to open such a buffer in another window, and setting the current colorscheme to itself in those buffers (e.g, running nvim unlisted_buffer "+set nobuflisted | Telescope colorscheme enable_preview=true" So I'm kinda on the fence about whether to include this patch in our defaults, because it doesn't work as expected in some (rather common) use cases. |
Thank you no matter what |
I tend to merge it and add the exception situations to wiki. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is gd enough too. agree with ayamir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with this too lol @Cyberczy thanks for the great work here!
…me (ayamir#1085) Signed-off-by: Cyberczy <[email protected]>
When I use fc to switch colorschemes,I can't see the change in real time.
So I made some changes