Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add docker support. #1081

Closed
wants to merge 2 commits into from
Closed

feat: add docker support. #1081

wants to merge 2 commits into from

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented Nov 26, 2023

aarnphm
aarnphm reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few tings

docker run --rm -it -v ${PWD}:/data ghcr.io/ayamir/nvimdots:nightly

docker run --rm -it -v ${PWD}:/data ghcr.io/anymir/nvimdots:stable

Dockerfile Outdated Show resolved Hide resolved
Dockerfile
cd ../ && rm -rf unibilium

# Install the latest stable neovim
RUN curl -LO https://github.com/neovim/neovim/releases/download/stable/nvim-linux64.tar.gz \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we include two variants? One stable and one nightly?

Probably can use multi-build here.

Dockerfile
RUN nvim --headless "+Lazy! sync" +qa

# Start with bash for the convenience of new changes
CMD ["bash"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For publishing to ghcr I recommend to also setup a actions to build for both arm and amd64

@ayamir @aarnphm
improve variable naming style.
d281ae1 
Co-authored-by: Aaron Pham <[email protected]>
Signed-off-by: Mohu <[email protected]>
CharlesChiuGit
CharlesChiuGit approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what aarnphm had already pointed out, i think it's go to go as a first draft.

@ayamir ayamir marked this pull request as draft November 30, 2023 08:01
@ayamir
Copy link
Owner Author

ayamir commented Mar 10, 2024

close because it seems meaningless...

@ayamir ayamir closed this Mar 10, 2024
@ayamir ayamir deleted the feat/docker branch March 10, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm left review comments

@CharlesChiuGit CharlesChiuGit CharlesChiuGit approved these changes

@Jint-lzxy Jint-lzxy Awaiting requested review from Jint-lzxy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayamir @aarnphm @CharlesChiuGit