fix: add old partitions constructor for backwards compatibility #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
ianbotsf
approved these changes
Sep 25, 2024
|
Could you provide an estimated timeline for when this fix might be available in the next version? FYI, we are experiencing significant user crashes in production (#1425). With this fix, we'd like to try the latest version to determine if the issue is resolved. |
1 task
|
This has been 2 weeks already and we are facing some crashes due to the old version in our production app. 😞 |
|
Any updates ? |
|
I'm working on updating this PR today. Hopefully we'll get it approved and released in the next day or two. |
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
|
|
A new generated diff is ready to view. |
Affected ArtifactsChanged in size
|
lauzadis
approved these changes
Oct 23, 2024
|
@drayan85 this change has been merged and should be present in today's SDK release v1.3.60. |
|
Thanks for getting it done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Possible fix for : #1411
Description of changes
This is re-adding a constructor that was removed from Kotlin to fix backwards incompatibility between versions < 1.2.8 to 1.3.39.
Relevant PR: #1335
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.