feat: codebuild ci workflow for external contributors #1207
Conversation
0marperez
added
the
no-changelog
|
A new generated diff is ready to view.
|
| @@ -29,6 +47,7 @@ jobs: | |||
| uses: aws-actions/aws-codebuild-run-build@v1 | |||
| with: | |||
| project-name: gh-aws-sdk-kotlin-e2e-tests | |||
| env-vars-for-codebuild: SDK_PR, SMITHY_PR | |||
There was a problem hiding this comment.
question: Why doesn't the service check batch job require similar changes? Why does it work (or does it)?
There was a problem hiding this comment.
I have to add similar changes to service-check-batch still
.github/workflows/codebuild-ci.yml
Outdated
| type: number | ||
| required: false | ||
| check-pr: | ||
| description: I verified that the PR's are not running any malicious code |
There was a problem hiding this comment.
Nit: PR's (possessive) → PRs (plural)
.github/workflows/codebuild-ci.yml
Outdated
| check-pr: | ||
| description: I verified that the PR's are not running any malicious code | ||
| required: true | ||
| type: boolean | ||
| default: false |
There was a problem hiding this comment.
Question: What does this setting actually do? I don't see it used anywhere else.
There was a problem hiding this comment.
It's meant as a reminder, it can be enforced though. The workflow could not run if the checkbox isn't marked
There was a problem hiding this comment.
I think enforcement is a good idea. A checkbox that has no effect and can be left unchecked with no repercussions seems pointless.
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
| @@ -38,21 +59,31 @@ jobs: | |||
| echo "cancelling in-progress build: id=$BUILD_ID" | |||
| aws codebuild stop-build --id $BUILD_ID | |||
| fi | |||
| - name: Verify PRs are not running malicious code | |||
There was a problem hiding this comment.
suggestion: Move this as the first step and you won't need the other if checks on each step. A failure of an earlier step will prevent it from running.
.github/workflows/codebuild-ci.yml
Outdated
| @@ -62,3 +93,8 @@ jobs: | |||
| echo "cancelling in-progress batch build: id=$BUILD_ID" | |||
| aws codebuild stop-build --id $BUILD_ID | |||
| fi | |||
| - name: Verify PRs are not running malicious code | |||
There was a problem hiding this comment.
Same suggestion, move to earlier and you won't need a conditional on every step
|
|
A new generated diff is ready to view.
|
Issue #
N/A
Description of changes
Added inputs to workflow. Inputs will be passed along to the codebuild job via env var
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.