Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
lauzadis committed Feb 7, 2024
1 parent 9e43b1b commit 80dfb81
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ public class S3ExpressCredentialsCache(
* * a new set of credentials are added to the cache (immediate refresh)
* * the `nextRefresh` time has been reached, which is either `DEFAULT_REFRESH_PERIOD` or
* the soonest credentials expiration time (minus a buffer), whichever comes first.
*
*/
private suspend fun refresh(): Unit {
val logger = coroutineContext.logger<S3ExpressCredentialsCache>()
Expand Down Expand Up @@ -106,6 +105,7 @@ public class S3ExpressCredentialsCache(
private suspend fun createSessionCredentials(key: S3ExpressCredentialsCacheKey): ExpiringValue<Credentials> {
val logger = coroutineContext.logger<S3ExpressCredentialsCache>()

// FIXME Consider creating a brand new client using the bootstrapped key.credentials instead of abusing the user's client
val credentials = (key.client as S3Client)
// de-configure interceptors because this key.client is the user's S3 client, and we don't want to
// execute their custom interceptors during this internal createSession request
Expand Down

0 comments on commit 80dfb81

Please sign in to comment.