Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cmake-js and tar to devDeps #335

Closed
wants to merge 1 commit into from
Closed

Move cmake-js and tar to devDeps #335

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 12, 2022

Issue #, if available:
Refs: #333

Description of changes:
Moves cmake-js and tar to devDeps

Testing:

The artifact for aws-crt is created by running npm pack in the workspace.

Before:

$ test-aws-crt> rm -rf * && npm init -y

$ test-aws-crt> npm install ../aws-crt-nodejs/aws-crt-1.0.0-dev.tgz

$ test-aws-crt> du -sh node_modules 
28M     node_modules

$ test-aws-crt> find node_modules -type d -maxdepth 1 | wc -l
118

After:

$ test-aws-crt> rm -rf * && npm init -y

$ test-aws-crt> npm install ../aws-crt-nodejs/aws-crt-1.0.0-dev.tgz

$ test-aws-crt> du -sh node_modules 
17M     node_modules

$ test-aws-crt> find node_modules -type d -maxdepth 1 | wc -l
56

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TwistedTwigleg
Copy link
Contributor

Unfortunately, currently we cannot remove cmake-js due to it being a build dependency when we need to build from source in a production NPM install. However, we did find a way to remove tar as a dependency.

Thank you for making this PR! While we cannot use it directly, it has been helpful 🙂
Closing in favor of #338

@trivikr trivikr deleted the move-tar-cmake-outside branch July 15, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants