Fix downstream build script. (#246)

Fix codebuild scripts to not need relative paths and use out of source builds.

CMakeLists.txt

@@ -30,9 +30,6 @@ file(GLOB AWS_COMMON_HEADERS
         "include/aws/common/*.h"
         "include/aws/common/*.inl"
         )
-# The generated config header doesn't exist yet, so don't use GLOB to try to find it
-# (as it'll skip the file if it doesn't exist yet)
-set(AWS_COMMON_HEADERS ${AWS_COMMON_HEADERS} ${GENERATED_CONFIG_HEADER})
 
 file(GLOB AWS_TEST_HEADERS
         "include/aws/testing/*.h"
@@ -153,7 +150,7 @@ if (HAVE_AVX2_INTRINSICS AND HAVE_SIMD_CPUID)
 endif()
 
 # Preserve subdirectories when installing headers
-foreach(HEADER_SRCPATH IN ITEMS ${AWS_COMMON_HEADERS} ${AWS_COMMON_OS_HEADERS} ${AWS_TEST_HEADERS})
+foreach(HEADER_SRCPATH IN ITEMS ${AWS_COMMON_HEADERS} ${AWS_COMMON_OS_HEADERS} ${GENERATED_CONFIG_HEADER} ${AWS_TEST_HEADERS})
     get_filename_component(HEADER_DIR ${HEADER_SRCPATH} DIRECTORY)
 # Note: We need to replace the generated include directory component first, otherwise if the build
 # directory is located inside the source tree, we'll partially rewrite the path and fail to replace it
@@ -210,14 +207,14 @@ install(FILES ${EXPORT_MODULES}
         DESTINATION "${LIBRARY_DIRECTORY}/cmake"
         COMPONENT Development)
 
+# This should come last, to ensure all variables defined by cmake will be available for export
+configure_file(${CONFIG_HEADER_TEMPLATE}
+        ${GENERATED_CONFIG_HEADER}
+        ESCAPE_QUOTES)
+
 if (NOT CMAKE_CROSSCOMPILING)
     include(CTest)
     add_subdirectory(tests)
 endif()
 
-# This should come last, to ensure all variables defined by cmake will be available for export
-configure_file(${CONFIG_HEADER_TEMPLATE}
-               ${GENERATED_CONFIG_HEADER}
-               ESCAPE_QUOTES)
-
 include(CPackConfig)

codebuild/ancient-linux-x64.yml

@@ -13,9 +13,9 @@ phases:
   build:
     commands:
       - echo Build started on `date`
-      - mkdir build
-      - cd build
-      - cmake ../
+      - mkdir /tmp/build
+      - cd /tmp/build
+      - cmake $CODEBUILD_SRC_DIR
       - make
       - ctest . --output-on-failure
   post_build:

codebuild/ancient-linux-x86.yml

@@ -13,9 +13,9 @@ phases:
   build:
     commands:
       - echo Build started on `date`
-      - mkdir build
-      - cd build
-      - cmake ../
+      - mkdir /tmp/build
+      - cd /tmp/build
+      - cmake $CODEBUILD_SRC_DIR
       - make
       - ctest . --output-on-failure
   post_build:

codebuild/common-posix.sh

@@ -2,11 +2,9 @@
 
 set -e
 
-mkdir build
-cd build
+mkdir /tmp/build
+cd /tmp/build
 
-cmake -DPERFORM_HEADER_CHECK=ON -DENABLE_SANITIZERS=ON $@ ../
+cmake -DPERFORM_HEADER_CHECK=ON -DENABLE_SANITIZERS=ON $@ $CODEBUILD_SRC_DIR
 make
 ctest . --output-on-failure
-
-cd ..

codebuild/common-windows.bat

@@ -1,7 +1,7 @@
 
-mkdir build
-cd build
-cmake %* -DPERFORM_HEADER_CHECK=ON -DCMAKE_BUILD_TYPE="Release" ../ || goto error
+mkdir %TEMP%\build
+cd  %TEMP%\build
+cmake %* -DPERFORM_HEADER_CHECK=ON -DCMAKE_BUILD_TYPE="Release" %CODEBUILD_SRC_DIR% || goto error
 msbuild.exe aws-c-common.vcxproj /p:Configuration=Release || goto error
 msbuild.exe tests/aws-c-common-assert-tests.vcxproj /p:Configuration=Release
 msbuild.exe tests/aws-c-common-tests.vcxproj /p:Configuration=Release

codebuild/downstream-posix.sh

@@ -7,8 +7,8 @@
 set -e
 set -x
 
-# everything is relative to the project root, which should be above this directory
-home_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/.. >/dev/null && pwd )"
+
+home_dir="/tmp"
 
 # where to have cmake put its binaries
 build_dir=$home_dir/build/downstream
@@ -22,7 +22,7 @@ function cmake_project {
     pushd $proj_dir
     mkdir -p ci-build
     cd ci-build
-    cmake -G"Unix Makefiles" $cmake_args -DCMAKE_INSTALL_PREFIX=$install_prefix ..
+    cmake -G"Unix Makefiles" $cmake_args -DCMAKE_PREFIX_PATH=$install_prefix -DCMAKE_INSTALL_PREFIX=$install_prefix ..
     cmake --build . --target all
     cmake --build . --target install
     if [[ $cmake_args != *"-DBUILD_TESTING=OFF"* ]]; then
@@ -72,7 +72,6 @@ do
     esac
 done
 
-cd $home_dir
 if [ $clean ]; then
     rm -rf $build_dir
 fi
@@ -90,6 +89,7 @@ fi
 cmake_project .
 
 # build master head rev of downstream projects
+cd $home_dir
 build_project aws-checksums
 build_project aws-c-event-stream
 build_project aws-c-io

codebuild/linux-clang3-x64.yml

@@ -14,7 +14,7 @@ phases:
     commands:
       - echo Build started on `date`
       - ./codebuild/common-posix.sh -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
-      - clang-tidy-3.9 -p=build **/*.c
+      - clang-tidy-3.9 -p=/tmp/build **/*.c
   post_build:
     commands:
       - echo Build completed on `date`

codebuild/linux-clang6-x64.yml

@@ -18,7 +18,7 @@ phases:
     commands:
       - echo Build started on `date`
       - ./codebuild/common-posix.sh -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_FUZZ_TESTS=ON
-      - clang-tidy-6.0 -p=build **/*.c
+      - clang-tidy-6.0 -p=/tmp/build **/*.c
       - ./format-check.sh
   post_build:
     commands: