Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: re-enable badssl endpoints #3352

Closed
wants to merge 1 commit into from
Closed

ci: re-enable badssl endpoints #3352

wants to merge 1 commit into from

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Jun 7, 2022

Description of changes:

Enables some endpoints which have re-newed their certs: #3300

Call-outs:

badssl certs seem to expire quite frequently and we have had to remove them from the list. Infact the below endpoints still dont work (expired certs or bad host down it seems). For long term sanity we should come up with a more permanent plan because the certs will expire again on August 15, 2022 and will need to be renewed.

#    {"endpoint": "sha384.badssl.com"},
#    {"endpoint": "sha512.badssl.com"},
#    {"endpoint": "tls-v1-0.badssl.com"},
#    {"endpoint": "tls-v1-1.badssl.com"},
#    {"endpoint": "tls-v1-2.badssl.com"},

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toidiu toidiu added the s2n-core team label Jun 7, 2022
@toidiu toidiu marked this pull request as ready for review June 8, 2022 05:08
@toidiu toidiu requested a review from lrstewart June 8, 2022 20:11
@toidiu
Copy link
Contributor Author

toidiu commented Jun 8, 2022

since the expiration is August 15, 2022 its not worth the temporary solution if badssl breaks again

@toidiu
Copy link
Contributor Author

toidiu commented Jun 8, 2022

#3353

@toidiu toidiu deleted the ak-cert branch August 30, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant