ci: temporarily remove test endpoints with expired certs #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Apr 5, 2022
goatgoose
approved these changes
Apr 6, 2022
lundinc2
added a commit
to lundinc2/s2n-tls
that referenced
this pull request
May 2, 2022
More certificates expired on 4/29/2022. Revert this commit when rsa4096.badssl.com has a non-expired certificate. Based on aws#3266.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
work around badssl issue
Description of changes:
Expired certs cause integration tests to fail.
Call-outs:
We need an internal reminder to check when this is resolved.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? CI
Is this a refactor change? no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.