Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add unregistered taint when nodes register #7616

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jan 20, 2025

Fixes #N/A

Description

  • Add node registration taint in userData for custom AMIs. All nodes that are launched by Karpenter will need the karpenter.sh/unregistered taint. Karpenter requires this taint to consider a node to have registered with the cluster. By default, all AMIs that Karpenter provides userData will include the taint. However, for custom AMIs Karpenter does not add any userData on the nodes. Therefore, all custom AMIs will need to add userData that would have otherwise been automatically add by Karpenter: https://karpenter.sh/docs/concepts/nodeclasses/#custom
  • The custom AMI test did not contain karpenter.sh/unregistered therefore our test was improperly considering the node not having registered

How was this change tested?

  • /karpenter versionCompatibility

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner January 20, 2025 20:45
@engedaam engedaam requested a review from edibble21 January 20, 2025 20:45
Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 849a899
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/678eb5ea6d67d00008bbcbe6

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8ffecc3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/678eb5f838243a0008ca12bc

Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter versionCompatibility

@coveralls
Copy link

coveralls commented Jan 20, 2025

Pull Request Test Coverage Report for Build 12875442938

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.986%

Totals Coverage Status
Change from base Build 12841205415: 0.0%
Covered Lines: 5776
Relevant Lines: 8888

💛 - Coveralls

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-8ffecc3083281009cdf9a64be6ba742b7346533b.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-8ffecc3083281009cdf9a64be6ba742b7346533b" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 319b209 into aws:main Jan 21, 2025
104 of 117 checks passed
@engedaam engedaam deleted the fix-custom-ami-taint branch January 21, 2025 17:21
edibble21 pushed a commit to edibble21/karpenter-provider-aws that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants