-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add unregistered taint when nodes register #7616
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
✅ Deploy Preview for karpenter-docs-prod canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter versionCompatibility
Pull Request Test Coverage Report for Build 12875442938Details
💛 - Coveralls |
Snapshot successfully published to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
karpenter.sh/unregistered
taint. Karpenter requires this taint to consider a node to have registered with the cluster. By default, all AMIs that Karpenter provides userData will include the taint. However, for custom AMIs Karpenter does not add any userData on the nodes. Therefore, all custom AMIs will need to add userData that would have otherwise been automatically add by Karpenter: https://karpenter.sh/docs/concepts/nodeclasses/#customkarpenter.sh/unregistered
therefore our test was improperly considering the node not having registeredHow was this change tested?
/karpenter versionCompatibility
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.