Ensure enabling local symbols doesn't change the module hash #2169
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2169 +/- ##
=======================================
Coverage 78.97% 78.97%
=======================================
Files 611 611
Lines 105552 105632 +80
Branches 14950 14951 +1
=======================================
+ Hits 83361 83428 +67
- Misses 21538 21554 +16
+ Partials 653 650 -3 ☔ View full report in Codecov by Sentry. |
andrewhop
force-pushed
the
fips_break_fix
branch
from
c869ea2 to
1c5642f
Compare
andrewhop
force-pushed
the
fips_break_fix
branch
from
1c5642f to
f016d3f
Compare
andrewhop
changed the title
skmcgrail
approved these changes
Feb 6, 2025
nebeid
approved these changes
Feb 6, 2025
andrewhop
added a commit
to andrewhop/aws-lc
that referenced
this pull request
Feb 6, 2025
### Description of changes: The original intention of aws#1005 was to ensure break-kat.go always worked with the library. aws#1252 then used a side effect to get the module hash but didn't actually fail the build if the hash was different. Turn on `pipefail` so the script exits unsuccessfully if any command fails even in a pipe. Previously if test-break-kat.sh failed the script didn't exit, instead it would continue to the grep which would also fail to find any matching string, and then the `|| true` ensured the script always continued on. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The original intention of #1005 was to ensure break-kat.go always worked with the library. #1252 then used a side effect to get the module hash but didn't actually fail the build if the hash was different.
Turn on
pipefailso the script exits unsuccessfully if any command fails even in a pipe. Previously if test-break-kat.sh failed the script didn't exit, instead it would continue to the grep which would also fail to find any matching string, and then the|| trueensured the script always continued on.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.