Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PQDSA to FIPSMODULE #2166

Merged
merged 6 commits into from
Feb 6, 2025
Merged

Move PQDSA to FIPSMODULE #2166

merged 6 commits into from
Feb 6, 2025

Conversation

jakemas
Copy link
Contributor

@jakemas jakemas commented Feb 4, 2025

Issues:

Resolves #CryptoAlg-2898

As part of validating ML-DSA into AWS-LC-FIPS we must include both PQDSA and ML-DSA directories into the fipsmodule.

Much like the series of PRs for ML-KEM we will implement this across split PRs:

This PR is part (1) move PQDSA, part (2) will be to move ML-DSA from crypto/ml_dsa/ to crypto/fipsmodule/ml_dsa/.

We did this once before:

But had to revert it here due to static fips builds for ARM failing in CI (CryptoAlg-2899):

We are now unblocked by:

Next up will be a repeat of:

Description of changes:

  • Move pqdsa and ml_dsa directories to fipsmodule
  • Move compilation of ML-DSA to bcm.c
  • Update EVP_PKEY_METHOD related structures

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (2c6ff65) to head (aa48e68).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2166      +/-   ##
==========================================
+ Coverage   78.97%   78.99%   +0.02%     
==========================================
  Files         611      611              
  Lines      105816   105904      +88     
  Branches    14976    14983       +7     
==========================================
+ Hits        83563    83658      +95     
+ Misses      21600    21593       -7     
  Partials      653      653              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakemas
Copy link
Contributor Author

jakemas commented Feb 6, 2025

This is a repeat of #2032 reviewed by @andrewhop and @torben-hansen previously.

@torben-hansen torben-hansen enabled auto-merge (squash) February 6, 2025 20:08
@torben-hansen torben-hansen merged commit a95190e into aws:main Feb 6, 2025
121 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants