Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ML-DSA key parsing #2152

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

samuel40791765
Copy link
Contributor

Issues:

Resolves P195558735

Description of changes:

This fixes a memory read misalignment in the ML-DSA public and private key parsing. I've also added new tests to verify that the test works. This should also fix the intermittent errors we've been having in our fuzz tests. The plan is to cut a release as soon as this is merged.

Call-outs:

N/A

Testing:

New tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (7965343) to head (75a3282).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2152      +/-   ##
==========================================
- Coverage   78.97%   78.96%   -0.01%     
==========================================
  Files         611      611              
  Lines      105541   105551      +10     
  Branches    14950    14949       -1     
==========================================
- Hits        83353    83352       -1     
- Misses      21533    21546      +13     
+ Partials      655      653       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 enabled auto-merge (squash) February 1, 2025 00:19
@samuel40791765 samuel40791765 merged commit e1513c3 into aws:main Feb 1, 2025
121 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants