-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross library PQ interop test with s2n-tls #2138
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2138 +/- ##
==========================================
- Coverage 78.97% 78.97% -0.01%
==========================================
Files 611 611
Lines 105551 105551
Branches 14950 14950
==========================================
- Hits 83362 83358 -4
- Misses 21536 21540 +4
Partials 653 653 ☔ View full report in Codecov by Sentry. |
a s2n-tls integration script exists: https://github.com/aws/aws-lc/blob/main/tests/ci/integration/run_s2n_integration.sh |
The intent of this work was to add a test that can test PQ-TLS interop between AWS-LC's libssl and different PQ-TLS providers of which S2N is one of several. That said, the naming of the script in this PR should be renamed to reflect that generic intent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add/augment a YAML file inside .github/workflows
to actually run this test. Assert that the test actually succeeds in the checks.
Our preference is to put this in the codebuild integration target like https://github.com/aws/aws-lc/blob/main/tests/ci/cdk/cdk/codebuild/github_ci_integration_omnibus.yaml#L9-L17 |
All targets in that yaml file are for |
I'd argue an interop test is an integration test and we could move the bash file. Either way this shouldn't run in the GitHub actions and should move to CodeBuild general or CodeBuild integration target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the build and it looks good! It also runs in 10 minutes which is great and using BUILD_GENERAL1_SMALL
makes sense.
Description of changes:
Adding cross library PQ interop test with s2n-tls
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.