Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross library PQ interop test with s2n-tls #2138

Merged
merged 9 commits into from
Feb 3, 2025
Merged

Conversation

chockalingamc
Copy link
Contributor

Description of changes:

Adding cross library PQ interop test with s2n-tls

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@chockalingamc chockalingamc requested a review from a team as a code owner January 24, 2025 15:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (138a6ad) to head (b1c622b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2138      +/-   ##
==========================================
- Coverage   78.97%   78.97%   -0.01%     
==========================================
  Files         611      611              
  Lines      105551   105551              
  Branches    14950    14950              
==========================================
- Hits        83362    83358       -4     
- Misses      21536    21540       +4     
  Partials      653      653              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torben-hansen
Copy link
Contributor

a s2n-tls integration script exists: https://github.com/aws/aws-lc/blob/main/tests/ci/integration/run_s2n_integration.sh
Should add any new tests to that IMO.

@geedo0
Copy link
Contributor

geedo0 commented Jan 28, 2025

a s2n-tls integration script exists: main/tests/ci/integration/run_s2n_integration.sh
Should add any new tests to that IMO.

The intent of this work was to add a test that can test PQ-TLS interop between AWS-LC's libssl and different PQ-TLS providers of which S2N is one of several. That said, the naming of the script in this PR should be renamed to reflect that generic intent.

Copy link
Contributor

@geedo0 geedo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add/augment a YAML file inside .github/workflows to actually run this test. Assert that the test actually succeeds in the checks.

tests/ci/run_s2n_interop_test.sh Outdated Show resolved Hide resolved
tests/ci/run_s2n_interop_test.sh Outdated Show resolved Hide resolved
tests/ci/run_s2n_interop_test.sh Outdated Show resolved Hide resolved
tests/ci/run_s2n_interop_test.sh Outdated Show resolved Hide resolved
tests/ci/run_s2n_interop_test.sh Outdated Show resolved Hide resolved
tests/ci/run_s2n_interop_test.sh Outdated Show resolved Hide resolved
@andrewhop
Copy link
Contributor

Add/augment a YAML file inside .github/workflows to actually run this test. Assert that the test actually succeeds in the checks.

Our preference is to put this in the codebuild integration target like https://github.com/aws/aws-lc/blob/main/tests/ci/cdk/cdk/codebuild/github_ci_integration_omnibus.yaml#L9-L17

@chockalingamc
Copy link
Contributor Author

Add/augment a YAML file inside .github/workflows to actually run this test. Assert that the test actually succeeds in the checks.

Our preference is to put this in the codebuild integration target like https://github.com/aws/aws-lc/blob/main/tests/ci/cdk/cdk/codebuild/github_ci_integration_omnibus.yaml#L9-L17

All targets in that yaml file are for tests/ci/integration/* test scripts. This test is interop testing for aws-lc with different libraries and resides in tests/ci/. The .github/workflows/misc-test.yaml seemed like an appropriate place for this.

@andrewhop
Copy link
Contributor

Add/augment a YAML file inside .github/workflows to actually run this test. Assert that the test actually succeeds in the checks.

Our preference is to put this in the codebuild integration target like https://github.com/aws/aws-lc/blob/main/tests/ci/cdk/cdk/codebuild/github_ci_integration_omnibus.yaml#L9-L17

All targets in that yaml file are for tests/ci/integration/* test scripts. This test is interop testing for aws-lc with different libraries and resides in tests/ci/. The .github/workflows/misc-test.yaml seemed like an appropriate place for this.

I'd argue an interop test is an integration test and we could move the bash file. Either way this shouldn't run in the GitHub actions and should move to CodeBuild general or CodeBuild integration target.

Copy link
Contributor

@andrewhop andrewhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the build and it looks good! It also runs in 10 minutes which is great and using BUILD_GENERAL1_SMALL makes sense.

tests/ci/integration/run_pq_tls_integration.sh Outdated Show resolved Hide resolved
@justsmth justsmth enabled auto-merge (squash) February 3, 2025 18:54
@justsmth justsmth merged commit 6c613fa into aws:main Feb 3, 2025
122 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants