Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate 2nd batch of CI jobs #2091

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

nhatnghiho
Copy link
Contributor

@nhatnghiho nhatnghiho commented Jan 2, 2025

Description of changes:

Migrate the following jobs from integrations.yml to CodeBuild:

  • tpm2-tss
  • tcpdump
  • socat
  • openldap
  • cyrus-sasl
  • libevent (excluded due to errors)
  • amazon-correto-crypto-provider

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@nhatnghiho nhatnghiho requested a review from a team as a code owner January 2, 2025 18:49
@nhatnghiho nhatnghiho force-pushed the codebuild-ci-migration branch from f2a1f6d to 6c703b5 Compare January 2, 2025 18:54
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (6c613fa) to head (81c77ef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2091   +/-   ##
=======================================
  Coverage   78.95%   78.96%           
=======================================
  Files         611      611           
  Lines      105551   105551           
  Branches    14950    14949    -1     
=======================================
+ Hits        83341    83351   +10     
+ Misses      21558    21549    -9     
+ Partials      652      651    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth
Copy link
Contributor

justsmth commented Jan 2, 2025

Should the corresponding GitHub CI workflows be removed in this PR, or in a subsequent one?

@nhatnghiho
Copy link
Contributor Author

Should the corresponding GitHub CI workflows be removed in this PR, or in a subsequent one?

It's in this PR. Just pushed it

@nhatnghiho nhatnghiho force-pushed the codebuild-ci-migration branch from 728af54 to 2d4b00d Compare January 2, 2025 20:10
@smittals2 smittals2 self-requested a review January 3, 2025 18:25
justsmth
justsmth previously approved these changes Jan 6, 2025
Copy link
Contributor

@smittals2 smittals2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhatnghiho nhatnghiho force-pushed the codebuild-ci-migration branch from 80f28d5 to dcc719f Compare February 3, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants