Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing algorithms to benchmark #2056

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nhatnghiho
Copy link
Contributor

Issues:

Resolves i/CryptoAlg-2808

Description of changes:

Add the following missing algorithms to speed.cc so we can view the benchmark on our dashboards:

  • Ciphers: rc4
  • Digests: md5-sha1,ripemd-160, shake128, shake256

Call-outs:

N/A

Testing:

CI. Verified that bssl runs successfully locally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@nhatnghiho nhatnghiho requested a review from a team as a code owner December 11, 2024 23:48
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (39b3fae) to head (0aeac07).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
- Coverage   78.75%   78.75%   -0.01%     
==========================================
  Files         598      598              
  Lines      103650   103650              
  Branches    14718    14718              
==========================================
- Hits        81633    81629       -4     
- Misses      21366    21369       +3     
- Partials      651      652       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrewhop
andrewhop previously approved these changes Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants