feat: Add Dafny standard libraries subset and partial streaming support to StandardLibrary #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com:aws/aws-cryptographic-material-providers-library-dafny into robin-aws/add-dafny-stdlibs-and-partial-streaming
…ithub.com:aws/aws-cryptographic-material-providers-library-dafny into robin-aws/add-dafny-stdlibs-and-partial-streaming # Conflicts: # StandardLibrary/runtimes/python/src/smithy_dafny_standard_library/internaldafny/generated/dafny_src-py.dtr
kessplas
reviewed
Feb 27, 2025
| self.dafny_byte_stream = dafny_byte_stream | ||
|
|
||
| def read(self, size: int = -1) -> bytes: | ||
| # TODO: assert size is -1, buffer, |
There was a problem hiding this comment.
is it possible to resolve this TODO at this time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds the same integration with Dafny's pending Actions standard library to partially support the
@streamingtrait, only when targeting Python for now.Uses the branch of smithy-dafny from smithy-lang/smithy-dafny#788, which should be merged first.
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.