feat(msk): support ServerlessCluster #32780
Conversation
github-actions
bot
added
effort/medium
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
mazyu36
force-pushed
the
msk-serverless
branch
from
b5f1c88 to
6147f11
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32780 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 222 222
Lines 13715 13715
Branches 2417 2417
=======================================
Hits 11181 11181
Misses 2254 2254
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| clientAuthentication: { | ||
| sasl: { | ||
| iam: { | ||
| enabled: true, |
There was a problem hiding this comment.
This property is required and cannot be false.
I tried deploying with enabled set to false, but the deployment failed with the following error:
A serverless cluster must use SASL/IAM authentication. (Service: Kafka, Status Code: 400, Request ID...As a result, I have decided not to expose this property.
| * | ||
| * @default - auto generate | ||
| */ | ||
| readonly clusterName?: string; |
There was a problem hiding this comment.
I didn't add clusterName validation because the correct regex pattern is unclear.
Please refer to #32792.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #28709.
Reason for this change
L2 Construct for MSK Serverless is not supported.
Description of changes
Add
ServerlessClusterclass.Describe any new or updated permissions being added
Nothing
Description of how you validated changes
Add unit tests and integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license