chore(aws-cdk-lib): fix so that the commandHook function is called only once during bundling.

[ayame113]

This is my first contribution to aws-cdk! So please let me know if I'm doing something wrong.

Issue # (if applicable)

Closes #31973.

Reason for this change

When using local bundling, the commandHook function was being called twice.
This PR fixes it so that it is only called once.

Description of changes

When the variable shouldBuildImage is true, a createBundlingCommand for the Docker build will be created as before.
When the variable shouldBuildImage is false, a createBundlingCommand for the local build will be created when bundler.local.tryBundle() is called. (Previously, both a createBundlingCommand for the Docker build and for the local build were created.)

After making this change, some tests failed because they were expecting the createBundlingCommand to be called immediately, so I added forcedDockerBundling: true to some of the tests.

Note: I was going to send a patch to aws-cdk-lib, but I found a similar code in aws-lambda-go-alpha, so I fixed it at the same time. Is that okay?

Description of how you validated changes

I've added a unit test.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[ayame113]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 2210271
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[lpizzinidev]

Thanks 👍
A couple of comments:

1. I'd classify the PR as a fix(lambda) instead of a chore (that will require an integration test update as well to verify the change)
2. Do we need to fix the behavior for Python runtimes as well?