Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-cdk-lib): catch another proptest failure #32751

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore(aws-cdk-lib): catch another proptest failure #32751

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f9fdedd
chore(aws-cdk-lib): catch another proptest failure
rix0rrr Jan 6, 2025
c09d367
Improve printing
rix0rrr Jan 6, 2025
1f344fe
Final fixes
rix0rrr Jan 7, 2025
d8ef2e5
Well that didn't help
rix0rrr Jan 8, 2025
ee57962
Well hot damn
rix0rrr Jan 8, 2025
e634bb5
This is mostly correct
rix0rrr Jan 8, 2025
dc80d95
Preserve legacy behavior
rix0rrr Jan 8, 2025
ca8757d
Why not
rix0rrr Jan 8, 2025
6927949
A more readable way to see this error
rix0rrr Jan 8, 2025
860cc08
Getting to this but it's still broken
rix0rrr Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/aws-cdk-lib/core/test/aspect.prop.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ test('inherited aspects get invoked before locally defined aspects, if both have

if (!(aInherited == true && bInherited == false)) return;

// But only if the application of aspect A exists at least as long as the application of aspect B
const aAppliedT = aspectAppliedT(testApp, a.aspect, a.construct);
const bAppliedT = aspectAppliedT(testApp, b.aspect, b.construct);

if (!(aAppliedT <= bAppliedT)) return;

if (!(a.index < b.index)) {
throw new Error(
`Aspect ${a.aspect}@${aPrio} at ${a.index} should have been before ${b.aspect}@${bPrio} at ${b.index}, but was after`,
Expand Down
Loading