-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): enforce no extra semicolons #32724
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -256,4 +256,4 @@ function mergeDeep(lhs: any, rhs: any): any { | |
} | ||
|
||
return rhs; | ||
}; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -563,7 +563,7 @@ export enum FeaturePlan { | |
ESSENTIALS = 'ESSENTIALS', | ||
/** Plus feature plan */ | ||
PLUS = 'PLUS', | ||
}; | ||
} | ||
|
||
/** | ||
* Props for the UserPool construct | ||
|
@@ -927,7 +927,7 @@ export class UserPool extends UserPoolBase { | |
|
||
const userPoolId = arnParts.resourceName; | ||
// ex) cognito-idp.us-east-1.amazonaws.com/us-east-1_abcdefghi | ||
const providerName = `cognito-idp.${arnParts.region}.${Stack.of(scope).urlSuffix}/${userPoolId}`;; | ||
const providerName = `cognito-idp.${arnParts.region}.${Stack.of(scope).urlSuffix}/${userPoolId}`; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 There are 18 occurrences of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would be similarly amazing to figure out why its happening and/or add a linter rule against it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @lpizzinidev @kaizencc |
||
|
||
class ImportedUserPool extends UserPoolBase { | ||
public readonly userPoolArn = userPoolArn; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be no eslint rule regarding semicolons in interface definitions, but the overwhelming majority of interface definitions in this file do not have semicolons.
Therefore, we believe that this semicolon should also be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this modification is not needed, I'll remove it.