Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): use CliIoHost as logger everywhere #32708
base: main
Are you sure you want to change the base?
chore(cli): use CliIoHost as logger everywhere #32708
Changes from 2 commits
d304251
12396ca
72c93da
498dde1
fa3513d
ea2f842
a5b59a6
6f9add3
306f08b
879fa3c
255dc60
cc2f7a9
ae48a18
3c6bb9b
65751a4
7e45655
b9a8c60
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 199 in packages/aws-cdk/lib/api/util/cloudformation/stack-activity-monitor.ts
Codecov / codecov/patch
packages/aws-cdk/lib/api/util/cloudformation/stack-activity-monitor.ts#L199
Check warning on line 630 in packages/aws-cdk/lib/api/util/cloudformation/stack-activity-monitor.ts
Codecov / codecov/patch
packages/aws-cdk/lib/api/util/cloudformation/stack-activity-monitor.ts#L630
Check warning on line 678 in packages/aws-cdk/lib/api/util/cloudformation/stack-activity-monitor.ts
Codecov / codecov/patch
packages/aws-cdk/lib/api/util/cloudformation/stack-activity-monitor.ts#L678
Check warning on line 682 in packages/aws-cdk/lib/api/util/cloudformation/stack-activity-monitor.ts
Codecov / codecov/patch
packages/aws-cdk/lib/api/util/cloudformation/stack-activity-monitor.ts#L682
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're going away from the
%ss
, which i support, we should do that here tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually people can still do %s. This is actually just a good catch that I don't need to do .toString anymore. It was previously more important.