-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli): make Deployments internal to Toolkit #32707
base: main
Are you sure you want to change the base?
Conversation
Changes the contract to only optionally take a `toolkitStackName` instead of a Deployments object. This is in preparation to cleaning up the contract for the public. Removes `toolkitStackName` from action options in favor of using the name from the Toolkit. However in reality these options were not actually in use. Also removes unused instances of `toolkitStackName` from `DeployStackOptions` and `RollbackStackOptions`. Like with the toolkit options, these weren't not actually passed on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32707 +/- ##
=======================================
Coverage 66.96% 66.97%
=======================================
Files 329 329
Lines 18663 18665 +2
Branches 3258 3255 -3
=======================================
+ Hits 12497 12500 +3
Misses 5839 5839
+ Partials 327 326 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e4ee7ba
to
ed7876d
Compare
ed7876d
to
070d1d7
Compare
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Reason for this change
Cleaning up the contract in preparation for the public release and removing unused options.
Description of changes
Changes the contract to optionally take a
toolkitStackName
instead of a fullDeployments
object.Removes
toolkitStackName
from various toolkit action options in favor of using the name from the toolkit. However in reality these options had no effect anyway.Also removes unused instances of
toolkitStackName
fromDeployStackOptions
andRollbackStackOptions
. Like with the toolkit options, these weren't not actually passed on.Describe any new or updated permissions being added
n/a
Description of how you validated changes
Run unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license