Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): make Deployments internal to Toolkit #32707

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jan 1, 2025

Reason for this change

Cleaning up the contract in preparation for the public release and removing unused options.

Description of changes

Changes the contract to optionally take a toolkitStackName instead of a full Deployments object.

Removes toolkitStackName from various toolkit action options in favor of using the name from the toolkit. However in reality these options had no effect anyway.

Also removes unused instances of toolkitStackName from DeployStackOptions and RollbackStackOptions. Like with the toolkit options, these weren't not actually passed on.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Run unit and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Changes the contract to only optionally take a  `toolkitStackName` instead of a Deployments object.
This is in preparation to cleaning up the contract for the public.

Removes `toolkitStackName` from action options in favor of using the name from the Toolkit.
However in reality these options were not actually in use.

Also removes unused instances of `toolkitStackName` from `DeployStackOptions` and  `RollbackStackOptions`. Like with the toolkit options, these weren't not actually passed on.
@mrgrain mrgrain requested a review from a team as a code owner January 1, 2025 18:02
@aws-cdk-automation aws-cdk-automation requested a review from a team January 1, 2025 18:02
@github-actions github-actions bot added the p2 label Jan 1, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 1, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.97%. Comparing base (3b162fc) to head (070d1d7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32707   +/-   ##
=======================================
  Coverage   66.96%   66.97%           
=======================================
  Files         329      329           
  Lines       18663    18665    +2     
  Branches     3258     3255    -3     
=======================================
+ Hits        12497    12500    +3     
  Misses       5839     5839           
+ Partials      327      326    -1     
Flag Coverage Δ
suite.unit 66.97% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.73% <77.77%> (+0.01%) ⬆️
packages/aws-cdk-lib/core 82.08% <ø> (ø)

@mrgrain mrgrain marked this pull request as draft January 2, 2025 00:18
@mrgrain mrgrain force-pushed the mrgrain/refactor/deployments-to-toolkit branch from e4ee7ba to ed7876d Compare January 2, 2025 13:16
@mrgrain mrgrain force-pushed the mrgrain/refactor/deployments-to-toolkit branch from ed7876d to 070d1d7 Compare January 2, 2025 13:20
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/32707/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 070d1d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-cli-test-run This PR needs CLI tests run against it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants