Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support lazy initialization of the SDK #74

Merged
merged 8 commits into from
Mar 18, 2024
Merged

feat: support lazy initialization of the SDK #74

merged 8 commits into from
Mar 18, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

@zhu-xiaowei zhu-xiaowei commented Mar 13, 2024

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. support lazy initialization of the SDK and will also send _first_open, _app_start and _session_start events.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Mar 13, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane March 13, 2024 09:21
@zhu-xiaowei zhu-xiaowei marked this pull request as draft March 13, 2024 09:29
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (60857e5) to head (07c7903).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #74      +/-   ##
============================================
+ Coverage     86.50%   86.70%   +0.19%     
- Complexity      458      468      +10     
============================================
  Files            42       42              
  Lines          1690     1707      +17     
  Branches        153      156       +3     
============================================
+ Hits           1462     1480      +18     
  Misses          150      150              
+ Partials         78       77       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review March 13, 2024 14:19
@zxkane zxkane merged commit eff7fe2 into main Mar 18, 2024
6 checks passed
@zxkane zxkane deleted the lazy-init-sdk branch March 18, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants