Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rule E1041 to validate Ref format #3914

Merged
merged 12 commits into from
Jan 24, 2025

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jan 14, 2025

Issue #, if available:
#3911
fix #639

Description of changes:

  • add rule E1041 to validate Ref format

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.67%. Comparing base (c2ccd76) to head (e04e921).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/cfnlint/context/context.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3914      +/-   ##
==========================================
- Coverage   93.81%   93.67%   -0.14%     
==========================================
  Files         366      370       +4     
  Lines       12538    12688     +150     
  Branches     2580     2478     -102     
==========================================
+ Hits        11763    11886     +123     
- Misses        429      443      +14     
- Partials      346      359      +13     
Flag Coverage Δ
unittests 93.67% <91.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the fix/issue/3911 branch 5 times, most recently from 9d13123 to c4a9ba0 Compare January 21, 2025 19:21
@kddejong kddejong force-pushed the fix/issue/3911 branch 2 times, most recently from 94e4f95 to 199889d Compare January 22, 2025 23:42
@kddejong kddejong force-pushed the fix/issue/3911 branch 2 times, most recently from 8bf2564 to 195c58e Compare January 23, 2025 19:15
@kddejong kddejong merged commit c0e2823 into aws-cloudformation:main Jan 24, 2025
24 of 25 checks passed
@kddejong kddejong deleted the fix/issue/3911 branch January 24, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoadBalancer doesn't verify SecurityGroups
1 participant