AWS::Config::ConfigurationRecorder.ResourceTypes AllowedValues expansion #1492
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Thanks for the contribution! Left a note on the issue if you're interesting in getting these fixes into all regions
alexmlee
force-pushed
the
missing-allowable-types
branch
from
96925a1 to
15efe4a
Compare
I updated the PR to have change the file the autogeneration stems from. Do I need to issue the command to auto-generate the region files and commit those as well? Thanks! |
PatMyron
changed the title
| "AWS::ApiGateway::DomainName", | ||
| "AWS::ApiGateway::Method", | ||
| "AWS::ApiGateway::RestApi", | ||
| "AWS::ApiGateway::Stage", | ||
| "AWS::ApiGatewayV2::DomainName", |
There was a problem hiding this comment.
not seeing these AWS::ApiGateway additions documented here or in the Config console
Do you know if they are recent additions or if there is somewhere else to find them?
There was a problem hiding this comment.
🤔 Huh! I swear they were in here last week.
| "AWS::ApiGatewayV2::Api", | ||
| "AWS::ApiGatewayV2::Stage", | ||
| "AWS::AutoScaling::AutoScalingGroup", | ||
| "AWS::AutoScaling::LaunchConfiguration", | ||
| "AWS::AutoScaling::ScalingPolicy", | ||
| "AWS::AutoScaling::ScheduledAction", | ||
| "AWS::CertificateManager::Certificate", |
There was a problem hiding this comment.
Do you know if this one should be AWS::ACM::Certificate or AWS::CertificateManager::Certificate?
There was a problem hiding this comment.
This one has also disappeared in the last week as an option. I think it was replaced by AWS::ACM::Certificate.
Source file should be enough, we can handle the autogeneration! |
alexmlee
force-pushed
the
missing-allowable-types
branch
from
c215e9e to
db4e144
Compare
|
@alexmlee should we merge these in? Or do you want to keep looking into the other resource types? |
I think this is ready to go! |
|
|
PatMyron
changed the title
fixes #1491
Description of changes:
Add new resource types
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.