[DBInstance] Revert isEngineMutable check to use previous model for same engine check #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moataz-mhmd
reviewed
Jan 25, 2024
aws-rds-dbinstance/src/main/java/software/amazon/rds/dbinstance/Translator.java
Show resolved
Hide resolved
aws-rds-dbinstance/src/main/java/software/amazon/rds/dbinstance/Translator.java
Show resolved
Hide resolved
elnaggar-amr
commented
Jan 25, 2024
aws-rds-dbinstance/src/main/java/software/amazon/rds/dbinstance/Translator.java
Show resolved
Hide resolved
moataz-mhmd
reviewed
Jan 25, 2024
aws-rds-dbinstance/src/main/java/software/amazon/rds/dbinstance/Translator.java
Show resolved
Hide resolved
moataz-mhmd
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Make sure you take care of the rollback situation when making one-way changes, like CDB conversion. Let me give you an example to explain how we handle rollback during modifications. You can check out AllocatedStorage parameter case here: DBInstance AllocatedStorage
moataz-mhmd
approved these changes
Feb 1, 2024
moataz-mhmd
changed the title
dbbh
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Revert isEngineMutable check to use previous model for same engine check
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.