[CustomDBEngineVersion] Update ListHandler logic to return only created custom #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moataz-mhmd
force-pushed
the
update-list-custom-engines-to-retrieve-only-created-engine-versions
branch
from
0e9063f to
0be3be7
Compare
khebul
reviewed
Nov 9, 2023
...stomdbengineversion/src/main/java/software/amazon/rds/customdbengineversion/ListHandler.java
Show resolved
Hide resolved
moataz-mhmd
force-pushed
the
update-list-custom-engines-to-retrieve-only-created-engine-versions
branch
from
0be3be7 to
45642bc
Compare
moataz-mhmd
force-pushed
the
update-list-custom-engines-to-retrieve-only-created-engine-versions
branch
from
45642bc to
4a641cc
Compare
dbbh
reviewed
Nov 13, 2023
...stomdbengineversion/src/main/java/software/amazon/rds/customdbengineversion/ListHandler.java
Show resolved
Hide resolved
…y-created-engine-versions
dbbh
reviewed
Nov 13, 2023
...ustomdbengineversion/src/main/java/software/amazon/rds/customdbengineversion/Translator.java
Show resolved
Hide resolved
dbbh
approved these changes
Nov 13, 2023
dbbh
pushed a commit
to dbbh/aws-cloudformation-resource-providers-rds
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In this code modification, I have adjusted the behavior to only return the custom engine versions that have been created, rather than returning all engine versions present in RDS.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.