[DBClusterParameterGroup] ReadHandler Includes Parameters #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 6, 2023 20:41
This commit adds `parameters` attribute to the response of the `ReadHandler`. The current implementation marks this attribute as write-only, which disqualifies the attribute for a drift detection. As a side effect, this code change includes a deep refactoring in this handler unit test suite. The refactoring promotes a wide use of the standard testing utility `test_handleRequest_base`. Signed-off-by: Oleg Sidorov <[email protected]>
moataz-mhmd
reviewed
Mar 7, 2023
There was a problem hiding this comment.
This resource has memory issue before due to high number of parameters. We used iterable before because we were using SDK paginators. Now, We are not using them anymore. We can avoid building extra iterables(list) and put results directly in accumulators maps. This could be simpler and more memory efficient.
...parametergroup/src/main/java/software/amazon/rds/dbclusterparametergroup/BaseHandlerStd.java
Show resolved
Hide resolved
moataz-mhmd
approved these changes
Mar 7, 2023
khebul
reviewed
Mar 7, 2023
...parametergroup/src/main/java/software/amazon/rds/dbclusterparametergroup/BaseHandlerStd.java
Show resolved
Hide resolved
...parametergroup/src/main/java/software/amazon/rds/dbclusterparametergroup/BaseHandlerStd.java
Show resolved
Hide resolved
khebul
approved these changes
Mar 8, 2023
angusy29
pushed a commit
to angusy29/aws-cloudformation-resource-providers-rds
that referenced
this pull request
Nov 6, 2024
…oudformation-resource-providers-rds into osdrv/merge-github-09-03-2023 # This is a combination of 4 commits. commit: bbeae619a01ffb32e48e2f3d75401e03a0fdf28c Author: Oleg Sidorov <[email protected]> Date: 2023-03-09T08:46:29.000Z Merge branch 'master' of https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-rds into osdrv/merge-github-09-03-2023 cr: https://code.amazon.com/reviews/CR-86955765 commit: 5584517 Author: Oleg Sidorov <[email protected]> Date: 2023-03-08T12:36:31.000Z [DBInstance] Set AllocatedStorage and Iops on rollback (aws-cloudformation#415) This commit instructs Translator to set `AllocatedStorage` and `Iops` unconditionally upon a rollback for instances with provisioned storage types. RDS API would reject a ModifyDBInstance request for provisioned storages if these attributes are missing. Signed-off-by: Oleg Sidorov <[email protected]> commit: e7917a1 Author: Oleg Sidorov <[email protected]> Date: 2023-03-08T12:26:44.000Z [DBClusterParameterGroup] ReadHandler Includes Parameters (aws-cloudformation#414) This commit adds `parameters` attribute to the response of the `ReadHandler`. The current implementation marks this attribute as write-only, which disqualifies the attribute for a drift detection. As a side effect, this code change includes a deep refactoring in this handler unit test suite. The refactoring promotes a wide use of the standard testing utility `test_handleRequest_base`. Signed-off-by: Oleg Sidorov <[email protected]> commit: 8ffcafe Author: moataz-mhmd <[email protected]> Date: 2023-03-03T14:44:49.000Z [DBCluster] Checking Failure Events After Mutating As Stabilization Step (aws-cloudformation#412) * [DBCluster] Checking Failure Events After Mutating As Stabilization Step * [DBCluster] Move checkFailedEvents and Timestamp to commons. * [DBCluster] Add NonNull to eventCategories. * [DBCluster] Update Method Signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
parametersattribute to the response of theReadHandler. The current implementation marks this attribute as write-only, which disqualifies the attribute for a drift detection.As a side effect, this code change includes a deep refactoring in this handler unit test suite. The refactoring promotes a wide use of the standard testing utility
test_handleRequest_base.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.