Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): reset api config on mock exit #9385

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

sundersc
Copy link
Contributor

@sundersc sundersc commented Dec 28, 2021

Description of changes

Reset Amplify meta and aws-exports.js file on mock exit.

Issue #, if available

#9338

Description of how you validated changes

  • manual test
  • yarn test

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sundersc sundersc requested a review from a team as a code owner December 28, 2021 07:15
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2021

Codecov Report

Merging #9385 (a3861d5) into master (4c12eb1) will increase coverage by 0.10%.
The diff coverage is 47.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9385      +/-   ##
==========================================
+ Coverage   55.36%   55.46%   +0.10%     
==========================================
  Files         887      888       +1     
  Lines       50331    50384      +53     
  Branches    10869    10894      +25     
==========================================
+ Hits        27866    27948      +82     
+ Misses      20393    20370      -23     
+ Partials     2072     2066       -6     
Impacted Files Coverage Δ
...oudformation/cdk-stack-builder/s3-stack-builder.ts 3.72% <0.00%> (-0.14%) ⬇️
...dformation/cdk-stack-builder/s3-stack-transform.ts 10.21% <0.00%> (ø)
...n/service-walkthrough-types/s3-user-input-types.ts 76.19% <ø> (ø)
...mation/service-walkthroughs/s3-user-input-state.ts 6.73% <0.00%> (-0.05%) ⬇️
...li-core/src/overrides-manager/migration-message.ts 42.85% <ø> (ø)
packages/amplify-cli/src/execution-manager.ts 7.83% <ø> (+0.50%) ⬆️
...fy-graphql-auth-transformer/src/resolvers/query.ts 67.00% <ø> (+7.00%) ⬆️
...es/amplify-graphql-index-transformer/src/schema.ts 97.34% <ø> (ø)
...plify-graphql-relational-transformer/src/schema.ts 94.91% <ø> (ø)
...-transformer/src/graphql-searchable-transformer.ts 93.26% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6334ea3...a3861d5. Read the comment docs.

@sundersc sundersc linked an issue Dec 29, 2021 that may be closed by this pull request
4 tasks
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests pass. Speaking of tests, is it possible to add a regression test?

@johnpc johnpc merged commit d0a76f4 into aws-amplify:master Jan 5, 2022
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Jan 10, 2022
@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.6.6 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.6.

@github-actions
Copy link

👋 Hi, this pull request was referenced in the v7.6.7 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v7.6.7.

@ggcespia
Copy link

ggcespia commented May 8, 2024

In amplify --version = 12.10.3 - this is happening again. The amplify configuration.json and was-exports.js files continually add back in the "aws_appsync_dangerously_connect_to_http_endpoint_for_testing": true,
I delete the line locally and it re-appears after every amplify push --y #9338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

amplify mock not reverting aws-exports.js on termination
6 participants