Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: smoke tests on windows #14053

Merged
merged 1 commit into from
Dec 31, 2024
Merged

fix: smoke tests on windows #14053

merged 1 commit into from
Dec 31, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Dec 31, 2024

Description of changes

Fix smoke tests on windows.

The error:

{"version":2,"width":120,"height":30,"timestamp":55.785,"title":"Recording","env":{}}
[0.084,"o","\u001b[40muser@host\u001b[49m\u001b[30m⮀\u001b[39m\u001b[44mC:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\amplify-e2e-tests\\amplify-app_940519\u001b[49m\u001b[34m⮀\u001b[39m C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe npx.cmd amplify-app --yes\r\n"]
[0.151,"o","\u001b[2J\u001b[m\u001b[H\u001b]0;Administrator: C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe\u0007\u001b[?25h"]
[0.42,"o","\u001b]0;npm\u0007"]
[0.508,"o","\u001b]0;npm exec amplify-app --yes\u0007"]
[1.955,"o","\u001b[1mnpm\u001b[22m \u001b[33mwarn \u001b[94mexec \u001b[mThe following package was not found and will be installed: [email protected]\r\n"]
[12.968,"o","\u001b[1mnpm\u001b[22m \u001b[33mwarn \u001b[94mdeprecated \u001b[[email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.\r\n"]
[13.706,"o","\u001b[1mnpm\u001b[22m \u001b[33mwarn \u001b[94mdeprecated \u001b[[email protected]: Rimraf versions prior to v4 are no longer supported\r\n"]
[14.085,"o","\u001b[1mnpm\u001b[22m \u001b[33mwarn \u001b[94mdeprecated \u001b[[email protected]: Glob versions prior to v9 are no longer supported\r\n"]
[19.654,"o","\u001b[1mnpm\u001b[22m \u001b[33mwarn \u001b[94mdeprecated \u001b[[email protected]: GraphQL Import has been deprecated and merged into GraphQL Tools, so it will no longer get updates. Use GraphQL Tools instead to stay up-to-date! Check out https://www.graphql-tools.com/docs/migration-from-import for migration and https://the-guild.dev/blog/graphql-tools-v6 for new changes.\r\n"]
[20.916,"o","\u001b[1mnpm\u001b[22m \u001b[33mwarn \u001b[94mdeprecated \u001b[[email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.\r\n"]
[24.727,"o","\u001b[1mnpm\u001b[22m \u001b[33mwarn \u001b[94mdeprecated \u001b[[email protected]: The library contains critical security issues and should not be used for production! The maintenance of the project has been discontinued. Consider migrating your code to isolated-vm.\r\n"]
[51.539,"o","\u001b]0;Administrator:  C:\\Windows\\system32\\cmd.exe \u0007"]
[54.714,"o","😟 Found Amplify CLI version 12.14.0-rc.9571383521. The minimum required version is >=5.0.0\r\n"]
[54.72,"o","😅 Installing Amplify CLI. Hold tight.\r\n😟 Amplify CLI was not found.\r\n😅 Installing Amplify CLI. Hold tight.\r\nError: spawn EINVAL\u001b[90m\r\n    at ChildProcess.spawn (node:internal/child_process:414:11)\r\n    at spawn (node:child_process:761:9)\u001b[m\r\n    at C:\\npm\\cache\\_npx\\8f0e0d1af0173654\\node_modules\\\u001b[4mamplify-app\u001b[24m\\src\\index.js:89:31\r\n    at new Promise (<anonymous>)\r\n    at installAmplifyCLI (C:\\npm\\cache\\_npx\\8f0e0d1af0173654\\node_modules\\\u001b[4mamplify-app\u001b[24m\\src\\index.js:88:10)\r\n    at amplifyCLIVersionCheck (C:\\npm\\cache\\_npx\\8f0e0d1af0173654\\node_modules\\\u001b[4mamplify-app\u001b[24m\\src\\index.js:131:11)\u001b[90m\r\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\u001b[m\r\n    at async Object.run (C:\\npm\\cache\\_npx\\8f0e0d1af0173654\\node_modules\\\u001b[4mamplify-app\u001b[24m\\src\\index.js:43:7) {\r\n  errno: \u001b[33m-4071\u001b[m,\r\n  code: \u001b[32m'EINVAL'\u001b[m,\r\n  syscall: \u001b[32m'spawn'\u001b[m\r\n}\r"]
[54.722,"o","\n"]
[54.763,"o","\u001b]0;Administrator: C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe\u0007"]
[55.785,"o","\u001b[40muser@host\u001b[49m\u001b[30m⮀\u001b[39m\u001b[44mC:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\amplify-e2e-tests\\amplify-app_940519\u001b[49m\u001b[34m⮀\u001b[39m \r\n"]

This is caused by nodejs/node#52554 .

This PR pins Node version to one compatible with Amplify App.

Issue #, if available

Description of how you validated changes

https://github.com/aws-amplify/amplify-cli/actions/runs/12562090767/job/35022052870

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner December 31, 2024 17:19
@sobolk sobolk merged commit 10adfbd into dev Dec 31, 2024
8 checks passed
@sobolk sobolk deleted the fix-smoke-tests-win branch December 31, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants