fix: do not create read stream for zip entries that are not being extracted #13792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0618
approved these changes
May 23, 2024
sobolk
reviewed
May 23, 2024
Comment on lines
+117
to
+119
| if (symlink) { | ||
| getAmplifyLogger().logError({ message: 'Found symlinks in the zipped directory. These symlinks will not be extracted' }); | ||
| return; |
There was a problem hiding this comment.
should we log what symlink is that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently we are abandoning a zip entry after creating a red stream for it which doesn't get closed as nobody read from it.
This PR avoids creating read stream for zip entries that we won't be extracting.
Also adds a log message when we detect symlink
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.