Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce active polling in code build workflows #13780

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented May 13, 2024

Description of changes

This PR removes active polling that was in place to mitigate CodeBuild graph evaluation inefficiencies. Please see #13121 for details about inefficiencies.

These inefficiencies has been adressed and this PR removes most of active polling. The only place with active polling that remains is the job that runs after all e2e tests and needs to await on all job ids. Producing depends-on statement for that job must remain in place for now due to us hitting YML file size limits.

Issue #, if available

Description of how you validated changes

Kicked off PR and E2E workflows.

Observed that jobs are awaiting on only required ones from previous level of nesting.

See

image

image

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk marked this pull request as ready for review May 13, 2024 22:13
@sobolk sobolk requested a review from a team as a code owner May 13, 2024 22:13
@sobolk sobolk changed the title chore: codebuild optimizations chore: reduce active polling in code build workflows May 13, 2024
@sobolk sobolk merged commit 3db951a into dev May 14, 2024
6 checks passed
@sobolk sobolk deleted the try-code-build-graph branch May 14, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants